Skip to content

Conversation

@h2parson
Copy link
Contributor

@h2parson h2parson commented Aug 1, 2025

Resolves issue #30

@h2parson
Copy link
Contributor Author

h2parson commented Aug 1, 2025

Not sure if the VALID_SLH_VAR_T macro is complete. Should adrs->u32 be memory no aliased?

@mkannwischer mkannwischer changed the title initial commit CBMC: Add prove and spec for adrs_set_hash_address Aug 2, 2025
@mkannwischer
Copy link
Contributor

Not sure if the VALID_SLH_VAR_T macro is complete. Should adrs->u32 be memory no aliased?

It is certainly not complete, but that is okay. We can extend it when another proof requires it.
No, you don't need another memory_no_alias for u32 as it's statically allocated - it's included in adrs.

Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes do look good to me, but the proofs time out.
Does this proof pass for you locally?

@h2parson h2parson requested a review from a team as a code owner August 13, 2025 19:54
@h2parson
Copy link
Contributor Author

The changes do look good to me, but the proofs time out. Does this proof pass for you locally?

Hi Matthias, sorry for the delay. This should be fixed now.

Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @h2parson. The changes LGTM. Can you please clean up the commit history (i.e., squash into one commit and make sure that it accurately reflects your changes).

@h2parson
Copy link
Contributor Author

It's squashed now.

@mkannwischer mkannwischer merged commit 64afc15 into pq-code-package:main Aug 15, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants