-
Notifications
You must be signed in to change notification settings - Fork 4
CBMC: Add prove and spec for adrs_set_hash_address
#32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not sure if the VALID_SLH_VAR_T macro is complete. Should adrs->u32 be memory no aliased? |
adrs_set_hash_address
It is certainly not complete, but that is okay. We can extend it when another proof requires it. |
mkannwischer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes do look good to me, but the proofs time out.
Does this proof pass for you locally?
Hi Matthias, sorry for the delay. This should be fixed now. |
mkannwischer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @h2parson. The changes LGTM. Can you please clean up the commit history (i.e., squash into one commit and make sure that it accurately reflects your changes).
|
It's squashed now. |
Signed-off-by: h2parson <[email protected]>
Resolves issue #30