Merge pull request #1688 from praw-dev/typing_improvments

Typing improvments

Author: LilSpazJoekp

praw/models/mod_action.py

@@ -1,5 +1,5 @@
 """Provide the ModAction class."""
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Union
 
 from .base import PRAWBase
 
@@ -16,5 +16,5 @@ def mod(self) -> "praw.models.Redditor":
         return self._reddit.redditor(self._mod)  # pylint: disable=no-member
 
     @mod.setter
-    def mod(self, value: "praw.models.Redditor"):
+    def mod(self, value: Union[str, "praw.models.Redditor"]):
         self._mod = value  # pylint: disable=attribute-defined-outside-init

praw/models/reddit/comment.py

@@ -16,7 +16,6 @@
 
 if TYPE_CHECKING:  # pragma: no cover
     from .... import praw
-    from ...reddit import models
 
 
 class Comment(InboxableMixin, UserContentMixin, FullnameMixin, RedditBase):
@@ -131,14 +130,14 @@ def replies(self) -> CommentForest:
         return self._replies
 
     @property
-    def submission(self) -> "models.Submission":
+    def submission(self) -> "praw.models.Submission":
         """Return the Submission object this comment belongs to."""
         if not self._submission:  # Comment not from submission
             self._submission = self._reddit.submission(self._extract_submission_id())
         return self._submission
 
     @submission.setter
-    def submission(self, submission: "models.Submission"):
+    def submission(self, submission: "praw.models.Submission"):
         """Update the Submission associated with the Comment."""
         submission._comments_by_id[self.fullname] = self
         self._submission = submission
@@ -170,7 +169,7 @@ def __init__(
     def __setattr__(
         self,
         attribute: str,
-        value: Union[str, "Redditor", "CommentForest", "models.subreddit.Subreddit"],
+        value: Union[str, Redditor, CommentForest, "praw.models.Subreddit"],
     ):
         """Objectify author, replies, and subreddit."""
         if attribute == "author":
@@ -210,7 +209,7 @@ def _extract_submission_id(self):
             return self.context.rsplit("/", 4)[1]
         return self.link_id.split("_", 1)[1]
 
-    def parent(self) -> Union["praw.models.Comment", "praw.models.Submission"]:
+    def parent(self) -> Union["Comment", "praw.models.Submission"]:
         """Return the parent of the comment.
 
         The returned parent will be an instance of either :class:`.Comment`, or