v2.0.0-beta.16

* Fix promisesForPopulate to fetch data in all cases

* Bump version

Author: fej-snikduj

package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-redux-firebase",
-  "version": "2.0.0-beta.15",
+  "version": "2.0.0-beta.16",
   "description": "Redux integration for Firebase. Comes with a Higher Order Components for use with React.",
   "main": "lib/index.js",
   "module": "es/index.js",

src/enhancer.js

@@ -50,7 +50,7 @@ let firebaseInstance
  * @param {Array|String} config.profileParamsToPopulate - Parameters within
  * profile object to populate. As of `v2.0.0` data is only loaded for population, not actually automatically populated
  * (allows access to both unpopulated and populated profile data).
- * @param {Boolean} config.autoPopulateProfile - **NOTE**: Not yet enabled for v2.0.0. Whether or not to
+ * @param {Boolean} config.autoPopulateProfile - **NOTE**: Now enabled for v2.0.0. Whether or not to
  * automatically populate profile with data loaded through profileParamsToPopulate config. (default: `true`)
  * @param {Boolean} config.setProfilePopulateResults - Whether or not to
  * call SET actions for data that results from populating profile to redux under

src/helpers.js

@@ -280,7 +280,7 @@ export const populate = (state, path, populates, notSetValue) => {
 
   if (!isArray(data)) {
     // check each populate child parameter for existence
-    const dataHasPopulateChilds = every(populatesForData, p =>
+    const dataHasPopulateChilds = some(populatesForData, p =>
       has(data, p.child)
     )
 

src/utils/populate.js

@@ -9,7 +9,7 @@ import {
   forEach,
   set,
   has,
-  every
+  some
 } from 'lodash'
 
 /**
@@ -137,7 +137,7 @@ export const promisesForPopulate = (firebase, dataKey, originalData, populatesIn
       : populatesIn
   )
 
-  const dataHasPopulateChilds = every(populatesForData, (populate) => (
+  const dataHasPopulateChilds = some(populatesForData, (populate) => (
     has(originalData, populate.child)
   ))
 
@@ -162,7 +162,8 @@ export const promisesForPopulate = (firebase, dataKey, originalData, populatesIn
       )
     })
   } else {
-    // Data is a map of objects, each value has parameters to be populated
+    // Data is a list of objects, each value has parameters to be populated
+    // { '1': {someobject}, '2': {someobject} }
     forEach(originalData, (d, key) => {
       // generate populates for this data item if a fn was passed
       const populatesForDataItem = getPopulateObj(isFunction(populatesIn)

tests/unit/utils/populate.spec.js

@@ -80,6 +80,12 @@ describe('Utils: Populate', () => {
       expect(res).to.have.deep.property(`users.${uid}`)
     })
 
+    it('populates all existing children even if one populates child does not exist', async () => {
+      populates = [{child: 'collaborators', root: 'users'}, {child: 'nonExistantKey', root: 'users'}]
+      res = await promisesForPopulate(Firebase, '', { collaborators: { [uid]: true, 'ABC123': true } }, populates)
+      expect(res).to.have.deep.property(`users.${uid}`)
+    })
+
     describe('populates list', () => {
       it('with single property populate', async () => {
         populates = [{child: 'owner', root: 'users'}]