(CONT-812) Correct Style/WordArray

chelnak · chelnak · commit 5ff69026d1d6 · 2023-04-17T16:28:20.000+01:00
diff --git a/lib/puppet-strings/yard/handlers/ruby/function_handler.rb b/lib/puppet-strings/yard/handlers/ruby/function_handler.rb
@@ -8,17 +8,17 @@
 # Implements the handler for Puppet functions written in Ruby.
 class PuppetStrings::Yard::Handlers::Ruby::FunctionHandler < PuppetStrings::Yard::Handlers::Ruby::Base
   # Represents the list of Puppet 4.x function API methods to support.
-  DISPATCH_METHOD_NAMES = [
-    'param',
-    'required_param',
-    'optional_param',
-    'repeated_param',
-    'optional_repeated_param',
-    'required_repeated_param',
-    'block_param',
-    'required_block_param',
-    'optional_block_param',
-    'return_type'
+  DISPATCH_METHOD_NAMES = %w[
+    param
+    required_param
+    optional_param
+    repeated_param
+    optional_repeated_param
+    required_repeated_param
+    block_param
+    required_block_param
+    optional_block_param
+    return_type
   ].freeze
 
   namespace_only
diff --git a/lib/puppet-strings/yard/handlers/ruby/provider_handler.rb b/lib/puppet-strings/yard/handlers/ruby/provider_handler.rb
@@ -94,7 +94,7 @@ def populate_provider_data(object)
 
           object.add_confine(node_as_string(kvp[0]) || kvp[0].source, node_as_string(kvp[1]) || kvp[1].source)
         end
-      elsif ['has_feature', 'has_features'].include?(method_name)
+      elsif %w[has_feature has_features].include?(method_name)
         # Add the features to the object
         parameters.each do |parameter|
           object.add_feature(node_as_string(parameter) || parameter.source)
diff --git a/lib/puppet-strings/yard/handlers/ruby/rsapi_handler.rb b/lib/puppet-strings/yard/handlers/ruby/rsapi_handler.rb
@@ -129,7 +129,7 @@ def populate_type_data(object, schema)
 
     schema['attributes'].each do |name, definition|
       # puts "Processing #{name}: #{definition.inspect}"
-      if ['parameter', 'namevar'].include? definition['behaviour']
+      if %w[parameter namevar].include? definition['behaviour']
         object.add_parameter(create_parameter(name, definition))
       else
         object.add_property(create_property(name, definition))
diff --git a/spec/unit/puppet-strings/markdown/base_spec.rb b/spec/unit/puppet-strings/markdown/base_spec.rb
@@ -27,11 +27,11 @@ class klass(Integer $param1, $param2, String $param3 = hi) inherits foo::bar {
       end
     end
 
-    ['examples',
-     'see',
-     'since',
-     'return_val',
-     'return_type'].each do |method|
+    %w[examples
+       see
+       since
+       return_val
+       return_type].each do |method|
       describe "##{method}" do
         it 'returns nil' do
           expect(component.method(method.to_sym).call).to be_nil
@@ -108,11 +108,11 @@ class klass::yeah(
       end
     end
 
-    ['summary',
-     'see',
-     'since',
-     'return_val',
-     'return_type'].each do |method|
+    %w[summary
+       see
+       since
+       return_val
+       return_type].each do |method|
       describe "##{method}" do
         it 'returns nil' do
           expect(component.method(method.to_sym).call).to be_nil
diff --git a/spec/unit/puppet-strings/yard/handlers/puppet/class_handler_spec.rb b/spec/unit/puppet-strings/yard/handlers/puppet/class_handler_spec.rb
@@ -54,7 +54,7 @@ class foo(Integer $param1, $param2, String $param3 = hi) inherits foo::bar {
       expect(object.namespace).to eq(PuppetStrings::Yard::CodeObjects::Classes.instance)
       expect(object.name).to eq(:foo)
       expect(object.statement).not_to be_nil
-      expect(object.parameters).to eq([['param1', nil], ['param2', nil], ['param3', 'hi']])
+      expect(object.parameters).to eq([['param1', nil], ['param2', nil], %w[param3 hi]])
       expect(object.docstring).to eq('A simple foo class.')
       expect(object.docstring.tags.size).to eq(4)
       tags = object.docstring.tags(:param)
diff --git a/spec/unit/puppet-strings/yard/handlers/puppet/defined_type_handler_spec.rb b/spec/unit/puppet-strings/yard/handlers/puppet/defined_type_handler_spec.rb
@@ -59,7 +59,7 @@
       expect(object.namespace).to eq(PuppetStrings::Yard::CodeObjects::DefinedTypes.instance)
       expect(object.name).to eq(:foo)
       expect(object.statement).not_to be_nil
-      expect(object.parameters).to eq([['param1', nil], ['param2', nil], ['param3', 'hi']])
+      expect(object.parameters).to eq([['param1', nil], ['param2', nil], %w[param3 hi]])
       expect(object.docstring).to eq('A simple foo defined type.')
       expect(object.docstring.tags.size).to eq(5)
       tags = object.docstring.tags(:param)
diff --git a/spec/unit/puppet-strings/yard/handlers/puppet/function_handler_spec.rb b/spec/unit/puppet-strings/yard/handlers/puppet/function_handler_spec.rb
@@ -55,7 +55,7 @@
       expect(object.namespace).to eq(PuppetStrings::Yard::CodeObjects::Functions.instance(PuppetStrings::Yard::CodeObjects::Function::PUPPET))
       expect(object.name).to eq(:foo)
       expect(object.signature).to eq('foo(Integer $param1, Any $param2, String $param3 = hi)')
-      expect(object.parameters).to eq([['param1', nil], ['param2', nil], ['param3', 'hi']])
+      expect(object.parameters).to eq([['param1', nil], ['param2', nil], %w[param3 hi]])
       expect(object.docstring).to eq('A simple foo function.')
       expect(object.docstring.tags.size).to eq(5)
       tags = object.docstring.tags(:param)
diff --git a/spec/unit/puppet-strings/yard/handlers/ruby/data_type_handler_spec.rb b/spec/unit/puppet-strings/yard/handlers/ruby/data_type_handler_spec.rb
@@ -305,7 +305,7 @@ def suppress_yard_logging
       # Check for default values
       expect(object.parameters.size).to eq(2)
       expect(object.parameters[0]).to eq(['msg', nil])
-      expect(object.parameters[1]).to eq(['arg1', 'param'])
+      expect(object.parameters[1]).to eq(%w[arg1 param])
 
       # Check for functions
       expect(object.functions.size).to eq(1)
diff --git a/spec/unit/puppet-strings/yard/handlers/ruby/function_handler_spec.rb b/spec/unit/puppet-strings/yard/handlers/ruby/function_handler_spec.rb
@@ -205,7 +205,7 @@ def foo(param1, param2, param3 = nil)
         expect(object.namespace).to eq(PuppetStrings::Yard::CodeObjects::Functions.instance(PuppetStrings::Yard::CodeObjects::Function::RUBY_4X))
         expect(object.name).to eq(:foo)
         expect(object.signature).to eq('foo(Integer $param1, Any $param2, Optional[String] $param3 = undef)')
-        expect(object.parameters).to eq([['param1', nil], ['param2', nil], ['param3', 'undef']])
+        expect(object.parameters).to eq([['param1', nil], ['param2', nil], %w[param3 undef]])
         expect(object.docstring).to eq('An example 4.x function.')
         expect(object.docstring.tags.size).to eq(5)
         tags = object.docstring.tags(:param)
diff --git a/spec/unit/puppet-strings/yard/handlers/ruby/provider_handler_spec.rb b/spec/unit/puppet-strings/yard/handlers/ruby/provider_handler_spec.rb
@@ -97,8 +97,8 @@
       expect(tags.size).to eq(1)
       expect(tags[0].text).to eq('public')
       expect(object.confines).to eq({ 'kernel' => 'Linux', 'osfamily' => 'RedHat' })
-      expect(object.defaults).to eq([[['kernel', 'Linux']], [['osfamily', 'RedHat'], ['operatingsystemmajrelease', '7']]])
-      expect(object.features).to eq(['implements_some_feature', 'some_other_feature'])
+      expect(object.defaults).to eq([[%w[kernel Linux]], [%w[osfamily RedHat], %w[operatingsystemmajrelease 7]]])
+      expect(object.features).to eq(%w[implements_some_feature some_other_feature])
       expect(object.commands).to eq({ 'foo' => '/usr/bin/foo' })
     end
   end
diff --git a/spec/unit/puppet-strings/yard/handlers/ruby/rsapi_handler_spec.rb b/spec/unit/puppet-strings/yard/handlers/ruby/rsapi_handler_spec.rb
@@ -122,12 +122,12 @@
       tags = object.docstring.tags(:api)
       expect(tags.size).to eq(1)
       expect(tags[0].text).to eq('public')
-      expect(object.properties.map(&:name)).to eq(['dynamic_prop', 'ensure', 'file', 'log_level'])
+      expect(object.properties.map(&:name)).to eq(%w[dynamic_prop ensure file log_level])
       expect(object.properties.size).to eq(4)
       expect(object.properties[0].name).to eq('dynamic_prop')
       expect(object.properties[0].docstring).to eq('Documentation for a dynamic property.')
       expect(object.properties[0].isnamevar).to be(false)
-      expect(object.properties[0].values).to eq(['foo', 'bar'])
+      expect(object.properties[0].values).to eq(%w[foo bar])
       expect(object.properties[1].name).to eq('ensure')
       expect(object.properties[1].docstring).to eq('What state the database should be in.')
       expect(object.properties[1].isnamevar).to be(false)
@@ -150,7 +150,7 @@
       expect(object.parameters[0].name).to eq('dynamic_param')
       expect(object.parameters[0].docstring).to eq('Documentation for a dynamic parameter.')
       expect(object.parameters[0].isnamevar).to be(false)
-      expect(object.parameters[0].values).to eq(['value1', 'value2'])
+      expect(object.parameters[0].values).to eq(%w[value1 value2])
       expect(object.parameters[1].name).to eq('address')
       expect(object.parameters[1].docstring).to eq('The database server name.')
       expect(object.parameters[1].isnamevar).to be(true)
diff --git a/spec/unit/puppet-strings/yard/handlers/ruby/type_handler_spec.rb b/spec/unit/puppet-strings/yard/handlers/ruby/type_handler_spec.rb
@@ -164,12 +164,12 @@
       expect(object.properties[0].name).to eq('dynamic_prop')
       expect(object.properties[0].docstring).to eq('Documentation for a dynamic property.')
       expect(object.properties[0].isnamevar).to be(false)
-      expect(object.properties[0].values).to eq(['foo', 'bar'])
+      expect(object.properties[0].values).to eq(%w[foo bar])
       expect(object.properties[1].name).to eq('ensure')
       expect(object.properties[1].docstring).to eq('What state the database should be in.')
       expect(object.properties[1].isnamevar).to be(false)
       expect(object.properties[1].default).to eq('up')
-      expect(object.properties[1].values).to eq(['present', 'absent', 'up', 'down'])
+      expect(object.properties[1].values).to eq(%w[present absent up down])
       expect(object.properties[1].aliases).to eq({ 'down' => 'absent', 'up' => 'present' })
       expect(object.properties[2].name).to eq('file')
       expect(object.properties[2].docstring).to eq('The database file to use.')
@@ -181,13 +181,13 @@
       expect(object.properties[3].docstring).to eq('The log level to use.')
       expect(object.properties[3].isnamevar).to be(false)
       expect(object.properties[3].default).to eq('warn')
-      expect(object.properties[3].values).to eq(['debug', 'warn', 'error'])
+      expect(object.properties[3].values).to eq(%w[debug warn error])
       expect(object.properties[3].aliases).to eq({})
       expect(object.parameters.size).to eq(5)
       expect(object.parameters[0].name).to eq('dynamic_param')
       expect(object.parameters[0].docstring).to eq('Documentation for a dynamic parameter.')
       expect(object.parameters[0].isnamevar).to be(false)
-      expect(object.parameters[0].values).to eq(['value1', 'value2'])
+      expect(object.parameters[0].values).to eq(%w[value1 value2])
       expect(object.parameters[1].name).to eq('address')
       expect(object.parameters[1].docstring).to eq('The database server name.')
       expect(object.parameters[1].isnamevar).to be(true)
@@ -204,13 +204,13 @@
       expect(object.parameters[3].docstring).to eq('Whether or not to encrypt the database.')
       expect(object.parameters[3].isnamevar).to be(false)
       expect(object.parameters[3].default).to eq('false')
-      expect(object.parameters[3].values).to eq(['true', 'false', 'yes', 'no'])
+      expect(object.parameters[3].values).to eq(%w[true false yes no])
       expect(object.parameters[3].aliases).to eq({})
       expect(object.parameters[4].name).to eq('backup')
       expect(object.parameters[4].docstring).to eq('How often to backup the database.')
       expect(object.parameters[4].isnamevar).to be(false)
       expect(object.parameters[4].default).to eq('never')
-      expect(object.parameters[4].values).to eq(['daily', 'monthly', 'never'])
+      expect(object.parameters[4].values).to eq(%w[daily monthly never])
       expect(object.features.size).to eq(2)
       expect(object.features[0].name).to eq('encryption')
       expect(object.features[0].docstring).to eq('The provider supports encryption.')
@@ -248,7 +248,7 @@
       expect(object.properties[0].name).to eq('ensure')
       expect(object.properties[0].docstring).to eq('The basic property that the resource should be in.')
       expect(object.properties[0].default).to eq('present')
-      expect(object.properties[0].values).to eq(['present', 'absent'])
+      expect(object.properties[0].values).to eq(%w[present absent])
     end
   end
 
