Fix getting GitHub owner for remote origin with https:// (#141)

Author: hugovk

pyproject.toml

@@ -14,6 +14,7 @@ exclude = [
   "^run_release.py$",
   "^sbom.py$",
   "^tests/test_release_tag.py$",
+  "^tests/test_run_release.py$",
   "^tests/test_sbom.py$",
   "^windows-release/purge.py$",
 ]

run_release.py

@@ -738,6 +738,17 @@ def execute_command(command: str) -> None:
     execute_command(f"find {destination} -type f -exec chmod 664 {{}} \\;")
 
 
+def extract_github_owner(url: str) -> str:
+    if https_match := re.match(r"(https://)?github\.com/([^/]+)/", url):
+        return https_match.group(2)
+    elif ssh_match := re.match(r"^git@github\.com:([^/]+)/", url):
+        return ssh_match.group(1)
+    else:
+        raise ReleaseException(
+            f"Could not parse GitHub owner from 'origin' remote URL: {url}"
+        )
+
+
 def start_build_of_source_and_docs(db: DbfilenameShelf) -> None:
     # Get the git commit SHA for the tag
     commit_sha = (
@@ -757,14 +768,7 @@ def start_build_of_source_and_docs(db: DbfilenameShelf) -> None:
         .decode()
         .strip()
     )
-    if https_match := re.match(r"github\.com/([^/]+)/", origin_remote_url):
-        origin_remote_github_owner = https_match.group(1)
-    elif ssh_match := re.match(r"^git@github\.com:([^/]+)/", origin_remote_url):
-        origin_remote_github_owner = ssh_match.group(1)
-    else:
-        raise ReleaseException(
-            f"Could not parse GitHub owner from 'origin' remote URL: {origin_remote_url}"
-        )
+    origin_remote_github_owner = extract_github_owner(origin_remote_url)
     # We ask for human verification at this point since this commit SHA is 'locked in'
     print()
     print(

tests/test_run_release.py

@@ -0,0 +1,24 @@
+import pytest
+
+import run_release
+
+
+@pytest.mark.parametrize(
+    ["url", "expected"],
+    [
+        ("github.com/hugovk/cpython.git", "hugovk"),
+        ("[email protected]:hugovk/cpython.git", "hugovk"),
+        ("https://github.com/hugovk/cpython.git", "hugovk"),
+    ],
+)
+def test_extract_github_owner(url: str, expected: str) -> None:
+    assert run_release.extract_github_owner(url) == expected
+
+
+def test_invalid_extract_github_owner() -> None:
+    with pytest.raises(
+        run_release.ReleaseException,
+        match="Could not parse GitHub owner from 'origin' remote URL: "
+        "https://example.com",
+    ):
+        run_release.extract_github_owner("https://example.com")

tox.ini

@@ -9,6 +9,7 @@ env_list =
 skip_install = true
 deps =
     -r dev-requirements.txt
+    -r requirements.txt
 commands =
     {envpython} -m pytest \
       tests/ \