Skip tests if installed backtrace format routine is stale

Author: lionel-

R/cnd-abort.R

@@ -268,6 +268,10 @@ find_capture_context <- function(n = 3L) {
 #' # stop("foo")
 NULL
 
+# Whenever the backtrace-on-error format is changed, the version in
+# `inst/backtrace-ver` and in `tests/testthat/helper-rlang.R` must be
+# bumped. This way `devtools::test()` will skip the tests that require
+# the dev version to be installed locally.
 format_onerror_backtrace <- function(cnd) {
   trace <- cnd$trace
   if (is_null(trace) || !trace_length(trace)) {

inst/backtrace-ver

@@ -0,0 +1 @@
+1.0.0

tests/testthat/helper-rlang.R

@@ -30,3 +30,16 @@ with_methods <- function(.expr, ...) {
   local_methods(...)
   .expr
 }
+
+# Some backtrace tests use Rscript, which requires the last version of
+# the backtrace code to be installed locally
+skip_if_stale_backtrace <- local({
+  current_backtrace_ver <- "1.0.0"
+
+  ver <- system.file("backtrace-ver", package = "rlang")
+  has_stale_backtrace <- ver == "" || !identical(readLines(ver), current_backtrace_ver)
+
+  function() {
+    skip_if(has_stale_backtrace)
+  }
+})

tests/testthat/test-cnd-abort.R

@@ -65,6 +65,7 @@ test_that("format_onerror_backtrace handles empty and size 1 traces", {
 
 test_that("error is printed with backtrace", {
   skip_unless_utf8()
+  skip_if_stale_backtrace()
 
   run_error_script <- function(envvars = chr()) {
     run_script(test_path("fixtures", "error-backtrace.R"), envvars = envvars)
@@ -114,6 +115,7 @@ test_that("error is printed with backtrace", {
 
 test_that("empty backtraces are not printed", {
   skip_unless_utf8()
+  skip_if_stale_backtrace()
 
   run_error_script <- function(envvars = chr()) {
     run_script(test_path("fixtures", "error-backtrace-empty.R"), envvars = envvars)
@@ -141,6 +143,7 @@ test_that("empty backtraces are not printed", {
 
 test_that("parent errors are not displayed in error message and backtrace", {
   skip_unless_utf8()
+  skip_if_stale_backtrace()
 
   run_error_script <- function(envvars = chr()) {
     run_script(

tests/testthat/test-cnd-error.R

@@ -9,6 +9,7 @@ test_that("error_cnd() checks its fields", {
 
 test_that("can use conditionMessage() method in subclasses of rlang errors", {
   skip_unless_utf8()
+  skip_if_stale_backtrace()
 
   run_error_script <- function(envvars = chr()) {
     run_script(