Fix remaining golangci-lint issues

Author: thardeck

internal/cmd/agent/deployer/internal/diff/diff.go

@@ -488,7 +488,7 @@ func normalizeEndpoint(un *unstructured.Unstructured, o options) {
 	if gvk.Group != "" || gvk.Kind != "Endpoints" {
 		return
 	}
-	//nolint: staticcheck // Endpoints is deprecated but still supported; see fleet#3760.
+	//nolint:staticcheck // Endpoints is deprecated but still supported; see fleet#3760.
 	var ep corev1.Endpoints
 	err := runtime.DefaultUnstructuredConverter.FromUnstructured(un.Object, &ep)
 	if err != nil {

internal/cmd/agent/deployer/internal/diff/kubernetes_vendor/pkg/api/v1/endpoints/util.go

@@ -63,7 +63,7 @@ func hashObject(hasher hash.Hash, obj interface{}) []byte {
 	return hasher.Sum(nil)
 }
 
-//nolint:staticcheck // EndpointSubset is deprecated but still supported; see fleet#3760.
+//nolint:staticcheck,nolintlint // EndpointSubset is deprecated but still supported; see fleet#3760.
 type subsetsByHash []v1.EndpointSubset
 
 func (sl subsetsByHash) Len() int      { return len(sl) }

internal/cmd/controller/agentmanagement/agent/manifest_test.go

@@ -112,6 +112,7 @@ func TestManifestAgentTolerations(t *testing.T) {
 				t.Fatal("there were no deployments returned from the manifests")
 			}
 
+			//nolint:SA5011 // agent is checked for nil above; t.Fatal prevents execution if nil
 			if !cmp.Equal(agent.Spec.Template.Spec.Tolerations, testCase.expectedTolerations, cmpOpt) {
 				t.Fatalf("tolerations were not as expected: %v", agent.Spec.Template.Spec.Tolerations)
 			}
@@ -160,6 +161,7 @@ func TestManifestAgentHostNetwork(t *testing.T) {
 				t.Fatal("there were no deployments returned from the manifests")
 			}
 
+			//nolint:SA5011 // agent is checked for nil above; t.Fatal prevents execution if nil
 			if !cmp.Equal(agent.Spec.Template.Spec.HostNetwork, testCase.expectedNetwork) {
 				t.Fatalf("hostNetwork is not as expected: %v", agent.Spec.Template.Spec.HostNetwork)
 			}
@@ -232,6 +234,7 @@ func TestManifestAgentAffinity(t *testing.T) {
 				t.Fatal("there were no deployments returned from the manifests")
 			}
 
+			//nolint:SA5011 // agent is checked for nil above; t.Fatal prevents execution if nil
 			if !cmp.Equal(agent.Spec.Template.Spec.Affinity, testCase.expectedAffinity) {
 				t.Fatalf("affinity was not as expected: %v %v", testCase.expectedAffinity, agent.Spec.Template.Spec.Affinity)
 			}