disable tab_apply_completion (tac) by default and rename as auto_complete_commit_on_tab (accot)

Author: marskar

radian/key_bindings.py

@@ -413,17 +413,17 @@ def is_callable(text=""):
             return False
 
     @Condition
-    def tac():
-        return settings.tab_apply_completion
+    def accot():
+        return settings.auto_complete_commit_on_tab
 
     insert_mode = vi_insert_mode | emacs_insert_mode
     focused_insert =  insert_mode & has_focus(DEFAULT_BUFFER)
     shown_not_selected = has_completions & ~completion_is_selected
     alt_enter = [KeyPress(Keys.Escape), KeyPress(Keys.Enter)]
 
     # apply selected completion
-    @handle('c-j', filter=focused_insert & completion_is_selected & tac)
-    @handle("enter", filter=focused_insert & completion_is_selected & tac)
+    @handle('c-j', filter=focused_insert & completion_is_selected & accot)
+    @handle("enter", filter=focused_insert & completion_is_selected & accot)
     def _(event):
         b = event.current_buffer
         text = b.text
@@ -435,8 +435,8 @@ def _(event):
             event.cli.key_processor.feed_multiple(alt_enter)
 
     # apply first completion option when completion menu is showing
-    @handle('c-j', filter=focused_insert & shown_not_selected & tac)
-    @handle("enter", filter=focused_insert & shown_not_selected & tac)
+    @handle('c-j', filter=focused_insert & shown_not_selected & accot)
+    @handle("enter", filter=focused_insert & shown_not_selected & accot)
     def _(event):
         b = event.current_buffer
         text = b.text
@@ -449,8 +449,8 @@ def _(event):
             event.cli.key_processor.feed_multiple(alt_enter)
 
     # apply completion if there is only one option, otherwise start completion
-    @handle("tab", filter=focused_insert & ~has_completions & tac)
-    @handle("c-space", filter=focused_insert & ~has_completions & tac)
+    @handle("tab", filter=focused_insert & ~has_completions & accot)
+    @handle("c-space", filter=focused_insert & ~has_completions & accot)
     def _(event):
         b = event.current_buffer
         complete_event = CompleteEvent(completion_requested=True)
@@ -465,8 +465,8 @@ def _(event):
             b.start_completion(insert_common_part=True)
 
     # apply first completion option if completion menu is showing
-    @handle("tab", filter=focused_insert & shown_not_selected & tac)
-    @handle("c-space", filter=focused_insert & shown_not_selected & tac)
+    @handle("tab", filter=focused_insert & shown_not_selected & accot)
+    @handle("c-space", filter=focused_insert & shown_not_selected & accot)
     def _(event):
         b = event.current_buffer
         b.complete_next()
@@ -476,8 +476,8 @@ def _(event):
             b.cursor_left()
 
     # apply selected completion option
-    @handle("tab", filter=focused_insert & completion_is_selected & tac)
-    @handle("c-space", filter=focused_insert & completion_is_selected & tac)
+    @handle("tab", filter=focused_insert & completion_is_selected & accot)
+    @handle("c-space", filter=focused_insert & completion_is_selected & accot)
     def _(event):
         b = event.current_buffer
         completion = b.complete_state.current_completion

radian/settings.py

@@ -38,7 +38,7 @@ def _load_prompt(self):
     def load(self):
         self._load_setting("auto_suggest", True, bool)
         self._load_setting("emacs_bindings_in_vi_insert_mode", True, bool)
-        self._load_setting("tab_apply_completion", True, bool)
+        self._load_setting("auto_complete_commit_on_tab", False, bool)
         self._load_setting("editing_mode", "emacs")
         self._load_setting("color_scheme", "native")
         self._load_setting("auto_match", True, bool)