Add cuda::std::span operator to cudf::column_view #20541
Merged
+85
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
libcudf
karthikeyann
approved these changes
Nov 7, 2025
Contributor
karthikeyann
left a comment
karthikeyann
left a comment
There was a problem hiding this comment.
Looks good to me.
nit: update cudf/cpp/tests/column/column_view_device_span_test.cpp too as part of this PR or new one.
bdice
approved these changes
Nov 7, 2025
Contributor
Author
|
/merge |
trxcllnt
pushed a commit
to trxcllnt/cudf
that referenced
this pull request
Nov 12, 2025
Adds a `cuda::std::span` operator to the `cudf::column_view` class to allow passing a column view instance directly to a span parameter or variable. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Karthikeyan (https://github.com/karthikeyann) - Bradley Dice (https://github.com/bdice) URL: rapidsai#20541
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
cuda::std::spanoperator to thecudf::column_viewclass to allow passing a column view instance directly to a span parameter or variable.Checklist