Skip to content

Chapter 16 typo #108

Description

@rickiepark

(p546) In a note, "Since the loss at time 1:t is dependent on the hidden units at all previous time steps 1:t" may be "Since the loss at time t is dependent on the hidden units at all previous time steps 1:t-1".

(p555) In middle code block,

>>> X_train = sequences[:25000,:]
>>> y_train = df.loc[:25000, 'sentiment'].values
>>> X_test = sequences[25000:,:]
>>> y_test = df.loc[25000:, 'sentiment'].values

As you may know, pandas' dataframe slicing includes start and end index.
Actually it is not a problem with this example, but I think it's better to change y_train = df.loc[:24999, 'sentiment'].values.

Thanks.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions