Skip to content

Commit 0931202

Browse files
SamChou19815facebook-github-bot
authored andcommitted
Require error code in suppressions, and kill $FlowIssue and $FlowIgnore in react-native (#53487)
Summary: Pull Request resolved: #53487 Changelog: [Internal] Reviewed By: marcoww6 Differential Revision: D81150232 fbshipit-source-id: 23320495061c7c78ced8f95db90101c4b55d9690
1 parent adf1b62 commit 0931202

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

.flowconfig

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@ module.system.haste.module_ref_prefix=m#
7575

7676
react.runtime=automatic
7777

78-
experimental.error_code_migration=new
78+
experimental.only_support_flow_fixme_and_expected_error=true
79+
experimental.require_suppression_with_error_code=true
7980

8081
ban_spread_key_props=true
8182

packages/debugger-shell/src/node/index.flow.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ function getShellBinaryAndArgs(
153153
switch (flavor) {
154154
case 'prebuilt':
155155
return [
156-
// $FlowIssue[cannot-resolve-module] fb-dotslash includes Flow types but Flow does not pick them up
156+
// $FlowFixMe[cannot-resolve-module] fb-dotslash includes Flow types but Flow does not pick them up
157157
require('fb-dotslash'),
158158
[DEVTOOLS_BINARY_DOTSLASH_FILE],
159159
];

packages/debugger-shell/src/node/private/LaunchUtils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ async function prepareDebuggerShellFromDotSlashFile(
4545
filePath: string,
4646
): Promise<DebuggerShellPreparationResult> {
4747
const {code, stderr} = await spawnAndGetStderr(
48-
// $FlowIssue[cannot-resolve-module] fb-dotslash includes Flow types but Flow does not pick them up
48+
// $FlowFixMe[cannot-resolve-module] fb-dotslash includes Flow types but Flow does not pick them up
4949
require('fb-dotslash'),
5050
['--', 'fetch', filePath],
5151
);

0 commit comments

Comments
 (0)