Implement private constructors for Performance APIs (#53430)

rubennorte · facebook-github-bot · commit 1716b3ca5cef · 2025-09-01T09:18:19.000-07:00
Summary: Pull Request resolved: #53430 Changelog: [internal] This fixes the spec-compliance of several classes in the Performance API by not allowing userland code to instantiate them directly. This also exposes some missing interfaces from the Performance API in the global scope. Reviewed By: rshest Differential Revision: D80800076 fbshipit-source-id: f6439b9c7914817ef552e78fd61646ccab1e1de2
diff --git a/packages/react-native/src/private/setup/setUpPerformanceObserver.js b/packages/react-native/src/private/setup/setUpPerformanceObserver.js
@@ -20,21 +20,34 @@ export default function setUpPerformanceObserver() {
   initialized = true;
 
   polyfillGlobal(
-    'PerformanceObserver',
+    'EventCounts',
+    () => require('../webapis/performance/EventTiming').EventCounts_public,
+  );
+
+  polyfillGlobal(
+    'Performance',
+    () => require('../webapis/performance/Performance').Performance_public,
+  );
+
+  polyfillGlobal(
+    'PerformanceEntry',
     () =>
-      require('../webapis/performance/PerformanceObserver').PerformanceObserver,
+      require('../webapis/performance/PerformanceEntry')
+        .PerformanceEntry_public,
   );
 
   polyfillGlobal(
-    'PerformanceObserverEntryList',
+    'PerformanceEventTiming',
     () =>
-      require('../webapis/performance/PerformanceObserver')
-        .PerformanceObserverEntryList,
+      require('../webapis/performance/EventTiming')
+        .PerformanceEventTiming_public,
   );
 
   polyfillGlobal(
-    'PerformanceEntry',
-    () => require('../webapis/performance/PerformanceEntry').PerformanceEntry,
+    'PerformanceLongTaskTiming',
+    () =>
+      require('../webapis/performance/LongTasks')
+        .PerformanceLongTaskTiming_public,
   );
 
   polyfillGlobal(
@@ -44,28 +57,33 @@ export default function setUpPerformanceObserver() {
 
   polyfillGlobal(
     'PerformanceMeasure',
-    () => require('../webapis/performance/UserTiming').PerformanceMeasure,
+    () =>
+      require('../webapis/performance/UserTiming').PerformanceMeasure_public,
   );
 
   polyfillGlobal(
-    'PerformanceEventTiming',
-    () => require('../webapis/performance/EventTiming').PerformanceEventTiming,
+    'PerformanceObserver',
+    () =>
+      require('../webapis/performance/PerformanceObserver').PerformanceObserver,
   );
 
   polyfillGlobal(
-    'PerformanceResourceTiming',
+    'PerformanceObserverEntryList',
     () =>
-      require('../webapis/performance/ResourceTiming')
-        .PerformanceResourceTiming,
+      require('../webapis/performance/PerformanceObserver')
+        .PerformanceObserverEntryList_public,
   );
 
   polyfillGlobal(
-    'TaskAttributionTiming',
-    () => require('../webapis/performance/LongTasks').TaskAttributionTiming,
+    'PerformanceResourceTiming',
+    () =>
+      require('../webapis/performance/ResourceTiming')
+        .PerformanceResourceTiming_public,
   );
 
   polyfillGlobal(
-    'PerformanceLongTaskTiming',
-    () => require('../webapis/performance/LongTasks').PerformanceLongTaskTiming,
+    'TaskAttributionTiming',
+    () =>
+      require('../webapis/performance/LongTasks').TaskAttributionTiming_public,
   );
 }
diff --git a/packages/react-native/src/private/webapis/performance/EventTiming.js b/packages/react-native/src/private/webapis/performance/EventTiming.js
@@ -70,6 +70,18 @@ export class PerformanceEventTiming extends PerformanceEntry {
   }
 }
 
+export const PerformanceEventTiming_public: typeof PerformanceEventTiming =
+  /* eslint-disable no-shadow */
+  // $FlowExpectedError[incompatible-type]
+  function PerformanceEventTiming() {
+    throw new TypeError(
+      "Failed to construct 'PerformanceEventTiming': Illegal constructor",
+    );
+  };
+
+// $FlowExpectedError[prop-missing]
+PerformanceEventTiming_public.prototype = PerformanceEventTiming.prototype;
+
 type EventCountsForEachCallbackType =
   | (() => void)
   | ((value: number) => void)
@@ -134,3 +146,15 @@ export class EventCounts {
     return getCachedEventCounts().values();
   }
 }
+
+export const EventCounts_public: typeof EventCounts =
+  /* eslint-disable no-shadow */
+  // $FlowExpectedError[incompatible-type]
+  function EventCounts() {
+    throw new TypeError(
+      "Failed to construct 'EventCounts': Illegal constructor",
+    );
+  };
+
+// $FlowExpectedError[prop-missing]
+EventCounts_public.prototype = EventCounts.prototype;
diff --git a/packages/react-native/src/private/webapis/performance/LongTasks.js b/packages/react-native/src/private/webapis/performance/LongTasks.js
@@ -24,6 +24,18 @@ export type PerformanceLongTaskTimingJSON = {
 
 export class TaskAttributionTiming extends PerformanceEntry {}
 
+export const TaskAttributionTiming_public: typeof TaskAttributionTiming =
+  /* eslint-disable no-shadow */
+  // $FlowExpectedError[incompatible-type]
+  function TaskAttributionTiming() {
+    throw new TypeError(
+      "Failed to construct 'TaskAttributionTiming': Illegal constructor",
+    );
+  };
+
+// $FlowExpectedError[prop-missing]
+TaskAttributionTiming_public.prototype = TaskAttributionTiming.prototype;
+
 const EMPTY_ATTRIBUTION: $ReadOnlyArray<TaskAttributionTiming> =
   Object.preventExtensions([]);
 
@@ -45,3 +57,16 @@ export class PerformanceLongTaskTiming extends PerformanceEntry {
     };
   }
 }
+
+export const PerformanceLongTaskTiming_public: typeof PerformanceLongTaskTiming =
+  /* eslint-disable no-shadow */
+  // $FlowExpectedError[incompatible-type]
+  function PerformanceLongTaskTiming() {
+    throw new TypeError(
+      "Failed to construct 'PerformanceLongTaskTiming': Illegal constructor",
+    );
+  };
+
+// $FlowExpectedError[prop-missing]
+PerformanceLongTaskTiming_public.prototype =
+  PerformanceLongTaskTiming.prototype;
diff --git a/packages/react-native/src/private/webapis/performance/Performance.js b/packages/react-native/src/private/webapis/performance/Performance.js
@@ -443,4 +443,16 @@ export default class Performance {
   }
 }
 
+export const Performance_public: typeof Performance =
+  /* eslint-disable no-shadow */
+  // $FlowExpectedError[incompatible-type]
+  function Performance() {
+    throw new TypeError(
+      "Failed to construct 'Performance': Illegal constructor",
+    );
+  };
+
+// $FlowExpectedError[prop-missing]
+Performance_public.prototype = Performance.prototype;
+
 setPlatformObject(Performance);
diff --git a/packages/react-native/src/private/webapis/performance/PerformanceEntry.js b/packages/react-native/src/private/webapis/performance/PerformanceEntry.js
@@ -77,6 +77,18 @@ export class PerformanceEntry {
   }
 }
 
+export const PerformanceEntry_public: typeof PerformanceEntry =
+  /* eslint-disable no-shadow */
+  // $FlowExpectedError[incompatible-type]
+  function PerformanceEntry() {
+    throw new TypeError(
+      "Failed to construct 'PerformanceEntry': Illegal constructor",
+    );
+  };
+
+// $FlowExpectedError[prop-missing]
+PerformanceEntry_public.prototype = PerformanceEntry.prototype;
+
 setPlatformObject(PerformanceEntry);
 
 export type PerformanceEntryList = $ReadOnlyArray<PerformanceEntry>;
diff --git a/packages/react-native/src/private/webapis/performance/PerformanceObserver.js b/packages/react-native/src/private/webapis/performance/PerformanceObserver.js
@@ -57,6 +57,19 @@ export class PerformanceObserverEntryList {
   }
 }
 
+export const PerformanceObserverEntryList_public: typeof PerformanceObserverEntryList =
+  /* eslint-disable no-shadow */
+  // $FlowExpectedError[incompatible-type]
+  function PerformanceObserverEntryList() {
+    throw new TypeError(
+      "Failed to construct 'PerformanceObserverEntryList': Illegal constructor",
+    );
+  };
+
+// $FlowExpectedError[prop-missing]
+PerformanceObserverEntryList_public.prototype =
+  PerformanceObserverEntryList.prototype;
+
 export type PerformanceObserverCallbackOptions = {
   droppedEntriesCount: number,
 };
diff --git a/packages/react-native/src/private/webapis/performance/ResourceTiming.js b/packages/react-native/src/private/webapis/performance/ResourceTiming.js
@@ -104,3 +104,16 @@ export class PerformanceResourceTiming extends PerformanceEntry {
     };
   }
 }
+
+export const PerformanceResourceTiming_public: typeof PerformanceResourceTiming =
+  /* eslint-disable no-shadow */
+  // $FlowExpectedError[incompatible-type]
+  function PerformanceResourceTiming() {
+    throw new TypeError(
+      "Failed to construct 'PerformanceResourceTiming': Illegal constructor",
+    );
+  };
+
+// $FlowExpectedError[prop-missing]
+PerformanceResourceTiming_public.prototype =
+  PerformanceResourceTiming.prototype;
diff --git a/packages/react-native/src/private/webapis/performance/UserTiming.js b/packages/react-native/src/private/webapis/performance/UserTiming.js
@@ -116,3 +116,15 @@ export const PerformanceMeasure: typeof PerformanceMeasureTemplate =
 
 // $FlowExpectedError[prop-missing]
 PerformanceMeasure.prototype = PerformanceMeasureTemplate.prototype;
+
+export const PerformanceMeasure_public: typeof PerformanceMeasure =
+  /* eslint-disable no-shadow */
+  // $FlowExpectedError[incompatible-type]
+  function PerformanceMeasure() {
+    throw new TypeError(
+      "Failed to construct 'PerformanceMeasure': Illegal constructor",
+    );
+  };
+
+// $FlowExpectedError[prop-missing]
+PerformanceMeasure_public.prototype = PerformanceMeasure.prototype;
diff --git a/packages/react-native/src/private/webapis/performance/__tests__/EventTimingAPI-itest.js b/packages/react-native/src/private/webapis/performance/__tests__/EventTimingAPI-itest.js
@@ -244,6 +244,21 @@ describe('Event Timing API', () => {
     expect([...performance.eventCounts.values()]).toEqual([1, 1, 3]);
   });
 
+  it('does NOT allow creating instances of PerformanceEventTiming directly', () => {
+    expect(() => {
+      return new PerformanceEventTiming();
+    }).toThrow(
+      "Failed to construct 'PerformanceEventTiming': Illegal constructor",
+    );
+  });
+
+  it('does NOT allow creating instances of EventCounts directly', () => {
+    expect(() => {
+      // $FlowExpectedError[cannot-resolve-name]
+      return new EventCounts();
+    }).toThrow("Failed to construct 'EventCounts': Illegal constructor");
+  });
+
   describe('durationThreshold option', () => {
     it('works when used with `type`', () => {
       const callback = jest.fn();
diff --git a/packages/react-native/src/private/webapis/performance/__tests__/LongTasksAPI-itest.js b/packages/react-native/src/private/webapis/performance/__tests__/LongTasksAPI-itest.js
@@ -191,4 +191,20 @@ describe('LongTasks API', () => {
       expect(entry.attribution).toEqual([]);
     });
   });
+
+  it('does NOT allow creating instances of PerformanceLongTaskTiming directly', () => {
+    expect(() => {
+      return new PerformanceLongTaskTiming();
+    }).toThrow(
+      "Failed to construct 'PerformanceLongTaskTiming': Illegal constructor",
+    );
+  });
+
+  it('does NOT allow creating instances of TaskAttributionTiming directly', () => {
+    expect(() => {
+      return new TaskAttributionTiming();
+    }).toThrow(
+      "Failed to construct 'TaskAttributionTiming': Illegal constructor",
+    );
+  });
 });
diff --git a/packages/react-native/src/private/webapis/performance/__tests__/Performance-itest.js b/packages/react-native/src/private/webapis/performance/__tests__/Performance-itest.js
@@ -0,0 +1,29 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow strict-local
+ * @format
+ */
+
+import '@react-native/fantom/src/setUpDefaultReactNativeEnvironment';
+
+import setUpPerformanceObserver from '../../../setup/setUpPerformanceObserver';
+
+setUpPerformanceObserver();
+
+describe('Performance', () => {
+  it('does NOT allow creating instances of Performance directly', () => {
+    expect(() => {
+      return new Performance();
+    }).toThrow("Failed to construct 'Performance': Illegal constructor");
+  });
+
+  it('does NOT allow creating instances of PerformanceEntry directly', () => {
+    expect(() => {
+      return new PerformanceEntry();
+    }).toThrow("Failed to construct 'PerformanceEntry': Illegal constructor");
+  });
+});
diff --git a/packages/react-native/src/private/webapis/performance/__tests__/PerformanceObserver-itest.js b/packages/react-native/src/private/webapis/performance/__tests__/PerformanceObserver-itest.js
@@ -11,6 +11,7 @@
 import '@react-native/fantom/src/setUpDefaultReactNativeEnvironment';
 
 import setUpPerformanceObserver from '../../../setup/setUpPerformanceObserver';
+import {PerformanceObserverEntryList_public} from '../PerformanceObserver';
 import * as Fantom from '@react-native/fantom';
 
 setUpPerformanceObserver();
@@ -117,4 +118,13 @@ describe('PerformanceObserver', () => {
       expect(callback).not.toHaveBeenCalled();
     });
   });
+
+  it('does NOT allow creating instances of PerformanceObserverEntryList directly', () => {
+    expect(() => {
+      // $FlowExpectedError[incompatible-type]
+      return new PerformanceObserverEntryList_public();
+    }).toThrow(
+      "Failed to construct 'PerformanceObserverEntryList': Illegal constructor",
+    );
+  });
 });
diff --git a/packages/react-native/src/private/webapis/performance/__tests__/UserTiming-itest.js b/packages/react-native/src/private/webapis/performance/__tests__/UserTiming-itest.js
@@ -44,6 +44,24 @@ describe('User Timing', () => {
     mockClock.uninstall();
   });
 
+  it('allows creating instances of PerformanceMark directly', () => {
+    const before = performance.now();
+    const entry = new PerformanceMark('mark-now');
+    const after = performance.now();
+
+    expect(entry).toBeInstanceOf(PerformanceMark);
+    expect(entry.startTime).toBeGreaterThanOrEqual(before);
+    expect(entry.startTime).toBeLessThanOrEqual(after);
+    expect(entry.duration).toBe(0);
+    expect(entry.detail).toBe(null);
+  });
+
+  it('does NOT allow creating instances of PerformanceMeasure directly', () => {
+    expect(() => {
+      return new PerformanceMeasure();
+    }).toThrow("Failed to construct 'PerformanceMeasure': Illegal constructor");
+  });
+
   describe('mark', () => {
     it('works with default timestamp', () => {
       mockClock.setTime(25);
