Commit 9539ddb
committed
Align legacy TypeScript ImageStyle with ViewStyle
The hand-written `ImageStyle` interface in `types_DEPRECATED` redeclared a
small subset of `ViewStyle` properties instead of extending it, so newer
style props such as `filter`, `boxShadow`, `mixBlendMode`, `outlineColor`
and `pointerEvents` were rejected on `<Image>` styles.
Both other sources of truth already include them: the Flow
`____ImageStyle_InternalCore` spreads `$Exact<____ViewStyle_Internal>`, and
the generated strict API declares `Omit<____ViewStyle_Internal, 'overflow'>`.
Extend `ViewStyle` with `overflow` omitted, mirroring the strict API, so
`overflow` stays narrowed to 'visible' | 'hidden' on images.1 parent 551d12a commit 9539ddb
2 files changed
Lines changed: 85 additions & 11 deletions
File tree
- packages/react-native
- __typetests__
- types_DEPRECATED/Libraries/StyleSheet
Lines changed: 84 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
Lines changed: 1 addition & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
638 | 638 | | |
639 | 639 | | |
640 | 640 | | |
641 | | - | |
| 641 | + | |
642 | 642 | | |
643 | | - | |
644 | | - | |
645 | | - | |
646 | | - | |
647 | | - | |
648 | | - | |
649 | | - | |
650 | | - | |
651 | 643 | | |
652 | 644 | | |
653 | 645 | | |
654 | | - | |
655 | 646 | | |
656 | | - | |
657 | 647 | | |
0 commit comments