Commit f53f3d3
committed
Fix crash when accessibilityRole="tabbar" is used on Android
tabbar is part of the public AccessibilityRole union in both Flow and
TypeScript with nothing marking it iOS-only, but the Android enum had
no TABBAR entry, so fromValue() threw during createViewInstance and the
app crashed on mount.
Add TABBAR to the enum and map it to android.view.View, alongside TAB
and TABLIST which also have no dedicated Android widget.
Fixes #578901 parent 2ab916f commit f53f3d3
2 files changed
Lines changed: 11 additions & 0 deletions
File tree
- packages/react-native/ReactAndroid/src
- main/java/com/facebook/react/uimanager
- test/java/com/facebook/react/uimanager
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
437 | 437 | | |
438 | 438 | | |
439 | 439 | | |
| 440 | + | |
440 | 441 | | |
441 | 442 | | |
442 | 443 | | |
| |||
491 | 492 | | |
492 | 493 | | |
493 | 494 | | |
| 495 | + | |
494 | 496 | | |
495 | 497 | | |
496 | 498 | | |
| |||
Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
347 | 347 | | |
348 | 348 | | |
349 | 349 | | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
350 | 359 | | |
351 | 360 | | |
352 | 361 | | |
| |||
0 commit comments