Fix AccessibilityRole list conversion

Summary:
Serialize `AccessibilityRole::List` as `list` and recognize `list` when parsing accessibility roles. Add exhaustive round-trip coverage for every named `AccessibilityRole`.

Changelog:
[General][Fixed] - Fix accessibility list role conversion in C++.

Differential Revision: D115746399

Author: Abbondanzo

packages/react-native/ReactCommon/react/renderer/components/view/accessibilityPropsConversions.h

@@ -349,7 +349,7 @@ inline std::string toString(const AccessibilityRole &accessibilityRole)
     case AccessibilityRole::Timer:
       return "timer";
     case AccessibilityRole::List:
-      return "timer";
+      return "list";
     case AccessibilityRole::Toolbar:
       return "toolbar";
     case AccessibilityRole::Grid:
@@ -441,6 +441,8 @@ inline void fromRawValue(const PropsParserContext &context, const RawValue &valu
       result = AccessibilityRole::Tablist;
     } else if (string == "timer") {
       result = AccessibilityRole::Timer;
+    } else if (string == "list") {
+      result = AccessibilityRole::List;
     } else if (string == "toolbar") {
       result = AccessibilityRole::Toolbar;
     } else if (string == "grid") {

packages/react-native/ReactCommon/react/renderer/components/view/tests/ConversionsTest.cpp

@@ -5,15 +5,88 @@
  * LICENSE file in the root directory of this source tree.
  */
 
+#include <array>
+
 #include <gtest/gtest.h>
 
 #include <react/renderer/attributedstring/conversions.h>
 #include <react/renderer/components/view/BoxShadowPropsConversions.h>
 #include <react/renderer/components/view/FilterPropsConversions.h>
+#include <react/renderer/components/view/accessibilityPropsConversions.h>
 #include <react/renderer/components/view/conversions.h>
 
 namespace facebook::react {
 
+TEST(ConversionsTest, accessibility_roles_round_trip) {
+  struct AccessibilityRoleTestCase {
+    AccessibilityRole role;
+    const char* name;
+  };
+
+  constexpr std::array accessibilityRoles{
+      AccessibilityRoleTestCase{AccessibilityRole::None, "none"},
+      AccessibilityRoleTestCase{AccessibilityRole::Button, "button"},
+      AccessibilityRoleTestCase{
+          AccessibilityRole::Dropdownlist, "dropdownlist"},
+      AccessibilityRoleTestCase{
+          AccessibilityRole::Togglebutton, "togglebutton"},
+      AccessibilityRoleTestCase{AccessibilityRole::Link, "link"},
+      AccessibilityRoleTestCase{AccessibilityRole::Search, "search"},
+      AccessibilityRoleTestCase{AccessibilityRole::Image, "image"},
+      AccessibilityRoleTestCase{AccessibilityRole::Keyboardkey, "keyboardkey"},
+      AccessibilityRoleTestCase{AccessibilityRole::Text, "text"},
+      AccessibilityRoleTestCase{AccessibilityRole::Adjustable, "adjustable"},
+      AccessibilityRoleTestCase{AccessibilityRole::Imagebutton, "imagebutton"},
+      AccessibilityRoleTestCase{AccessibilityRole::Header, "header"},
+      AccessibilityRoleTestCase{AccessibilityRole::Summary, "summary"},
+      AccessibilityRoleTestCase{AccessibilityRole::Alert, "alert"},
+      AccessibilityRoleTestCase{AccessibilityRole::Checkbox, "checkbox"},
+      AccessibilityRoleTestCase{AccessibilityRole::Combobox, "combobox"},
+      AccessibilityRoleTestCase{AccessibilityRole::Menu, "menu"},
+      AccessibilityRoleTestCase{AccessibilityRole::Menubar, "menubar"},
+      AccessibilityRoleTestCase{AccessibilityRole::Menuitem, "menuitem"},
+      AccessibilityRoleTestCase{AccessibilityRole::Progressbar, "progressbar"},
+      AccessibilityRoleTestCase{AccessibilityRole::Radio, "radio"},
+      AccessibilityRoleTestCase{AccessibilityRole::Radiogroup, "radiogroup"},
+      AccessibilityRoleTestCase{AccessibilityRole::Scrollbar, "scrollbar"},
+      AccessibilityRoleTestCase{AccessibilityRole::Spinbutton, "spinbutton"},
+      AccessibilityRoleTestCase{AccessibilityRole::Switch, "switch"},
+      AccessibilityRoleTestCase{AccessibilityRole::Tab, "tab"},
+      AccessibilityRoleTestCase{AccessibilityRole::Tabbar, "tabbar"},
+      AccessibilityRoleTestCase{AccessibilityRole::Tablist, "tablist"},
+      AccessibilityRoleTestCase{AccessibilityRole::Timer, "timer"},
+      AccessibilityRoleTestCase{AccessibilityRole::List, "list"},
+      AccessibilityRoleTestCase{AccessibilityRole::Toolbar, "toolbar"},
+      AccessibilityRoleTestCase{AccessibilityRole::Grid, "grid"},
+      AccessibilityRoleTestCase{AccessibilityRole::Pager, "pager"},
+      AccessibilityRoleTestCase{AccessibilityRole::Scrollview, "scrollview"},
+      AccessibilityRoleTestCase{
+          AccessibilityRole::Horizontalscrollview, "horizontalscrollview"},
+      AccessibilityRoleTestCase{AccessibilityRole::Viewgroup, "viewgroup"},
+      AccessibilityRoleTestCase{AccessibilityRole::Webview, "webview"},
+      AccessibilityRoleTestCase{
+          AccessibilityRole::Drawerlayout, "drawerlayout"},
+      AccessibilityRoleTestCase{
+          AccessibilityRole::Slidingdrawer, "slidingdrawer"},
+      AccessibilityRoleTestCase{AccessibilityRole::Iconmenu, "iconmenu"},
+  };
+  static_assert(
+      accessibilityRoles.size() ==
+      static_cast<size_t>(AccessibilityRole::Iconmenu) + 1);
+
+  const PropsParserContext context{-1, ContextContainer{}};
+  for (const auto& [role, name] : accessibilityRoles) {
+    SCOPED_TRACE(name);
+    EXPECT_EQ(toString(role), name);
+
+    AccessibilityRole parsedRole = role == AccessibilityRole::None
+        ? AccessibilityRole::Button
+        : AccessibilityRole::None;
+    fromRawValue(context, RawValue{folly::dynamic(name)}, parsedRole);
+    EXPECT_EQ(parsedRole, role);
+  }
+}
+
 TEST(ConversionsTest, unprocessed_box_shadow_string) {
   RawValue value{
       folly::dynamic("10px 2px 0 5px #fff, inset 20px 10px 5px 0 #000")};