`offlineAvailability` in `ReadiumSpeechVoice` is not typed and falls back to implicit any

[panaC]

speech/src/WebSpeech/WebSpeechVoiceManager.ts

Line 586 in 33404e4

offlineAvailability: voice.localService || false,

speech/src/voices/types.ts

Line 104 in 33404e4

[key: string]: any;

[panaC]

This bypasses type safety entirely and can hide integration or runtime issues. In particular, a wildcard any fallback should be avoided because it silently disables type checking, while a typed explicit cast is preferred in this case.

[panaC]

I suggest removing [key: string]: any and using an explicit cast for the missing JSON key when needed. This also allows proper derivation of the object type interface.

[panaC]

In TypeScript, we could perhaps use the satisfies operator more often. I didn't use it so much.

[JayPanoz]

That would be an artefact of development that could not be caught in demos because they are vanilla JS, sorry for the oversight. We've had a pretty intense period of adjustments and corrections near the end of the initial version dev so it definitely slips through the cracks in the absence of a review.

satisfies has been in the back of my head for a while, as I'd like to introduce it in Readium Web TS projects for this reason. So we're on the same wavelength here I guess.

Will try to address this soon-ish as I have to deal with the Decorator API in TS-TOOLKIT as the topmost priority.

If it's super urgent and you find time to open a PR yourself you can probably go ahead tho. Chances are it would happen before I can take a proper look this week – especially as Friday is a bank holiday.

[panaC]

Thanks, and just to clarify, this really isn’t a problem for me, my message was more of an informative issue-tracking note than anything else. No worries at all, and no rush.

Happy bank holiday too :) !

[JayPanoz]

Oh no worries this is how I understood it. Wasn't sure if you were actively implementing it and I didn't want you to have to wait on me if that was better fixed sooner than later.

As a timeline, I will come back to it soon-ish since I am dealing with Media Overlays and TTS as an epic in TS Toolkit and Thorium Web. So that's probably happening early next month.