kueue: skip old platform param if new param exists in production (#9125)

If both the old and the new platform params exist in the pipelinerun, we
should only pull from the new platform params. The old parameters are
likely going to be something we can't interpret with CEL expressions if
the new paramter is set. To avoid issues, only read from the old
expressions if the new expressions are not set.

See KONFLUX-9917 for issues that have already cropped up in our
production clusters.

Fixes: KONFLUX-9917

Signed-off-by: Andy Sadler <[email protected]>

Author: sadlerap

components/kueue/production/base/tekton-kueue/config.yaml

@@ -38,6 +38,10 @@ cel:
 
     # Set resource requests for multi platform pipelines which doesn't use the build-platforms parameter (old style)
     - |
+      !(
+        has(pipelineRun.spec.params) &&
+        pipelineRun.spec.params.exists(p, p.name == 'build-platforms')
+      ) &&
       has(pipelineRun.spec.pipelineSpec) &&
       has(pipelineRun.spec.pipelineSpec.tasks) &&
       pipelineRun.spec.pipelineSpec.tasks.size() > 0 ?
@@ -53,6 +57,10 @@ cel:
 
     # Request AWS IP for AWS-based platforms which doesn't use the build-platforms parameter (old style)
     - |
+      !(
+        has(pipelineRun.spec.params) &&
+        pipelineRun.spec.params.exists(p, p.name == 'build-platforms')
+      ) &&
       has(pipelineRun.spec.pipelineSpec) &&
       has(pipelineRun.spec.pipelineSpec.tasks) &&
       pipelineRun.spec.pipelineSpec.tasks.size() > 0 ?

hack/test-tekton-kueue-config.py

@@ -769,6 +769,10 @@ def check_prerequisites(should_print: bool = True) -> Dict[str, TestConfig]:
         "pipelinerun_key": "mintmaker",
         "config_key": "production"
     },
+    "prefer_new_parameters_staging": {
+        "pipelinerun_key": "prefer-new-parameters",
+        "config_key": "production"
+    },
 
     # Example: Test the same PipelineRun with different configs to show reusability
     "user-specific-priority_and_mixed_platforms_production-kflux-ocp-p01": {