Merge pull request #1133 from ssi02014/imp/types

refactor(domToReact): refactoring  multiple types

Author: remarkablemark

src/attributes-to-props.ts

@@ -9,8 +9,13 @@ import { PRESERVE_CUSTOM_ATTRIBUTES, setStyleProp } from './utilities';
 
 // https://react.dev/learn/sharing-state-between-components#controlled-and-uncontrolled-components
 // https://developer.mozilla.org/docs/Web/HTML/Attributes
-const UNCONTROLLED_COMPONENT_ATTRIBUTES = ['checked', 'value'];
-const UNCONTROLLED_COMPONENT_NAMES = ['input', 'select', 'textarea'];
+const UNCONTROLLED_COMPONENT_ATTRIBUTES = ['checked', 'value'] as const;
+const UNCONTROLLED_COMPONENT_NAMES = ['input', 'select', 'textarea'] as const;
+
+type UncontrolledComponentAttributes =
+  (typeof UNCONTROLLED_COMPONENT_ATTRIBUTES)[number];
+
+type UncontrolledComponentNames = (typeof UNCONTROLLED_COMPONENT_NAMES)[number];
 
 const valueOnlyInputs = {
   reset: true,
@@ -63,8 +68,12 @@ export default function attributesToProps(
 
       // convert attribute to uncontrolled component prop (e.g., `value` to `defaultValue`)
       if (
-        UNCONTROLLED_COMPONENT_ATTRIBUTES.indexOf(propName) !== -1 &&
-        UNCONTROLLED_COMPONENT_NAMES.indexOf(nodeName!) !== -1 &&
+        UNCONTROLLED_COMPONENT_ATTRIBUTES.indexOf(
+          propName as UncontrolledComponentAttributes,
+        ) !== -1 &&
+        UNCONTROLLED_COMPONENT_NAMES.indexOf(
+          nodeName! as UncontrolledComponentNames,
+        ) !== -1 &&
         !isInputValueOnly
       ) {
         propName = getPropName('default' + attributeNameLowerCased);

src/dom-to-react.ts

@@ -37,10 +37,9 @@ export default function domToReact(
   const { cloneElement, createElement, isValidElement } =
     options?.library || React;
 
-  let index = 0;
   const nodesLength = nodes.length;
 
-  for (; index < nodesLength; index++) {
+  for (let index = 0; index < nodesLength; index++) {
     const node = nodes[index];
 
     // replace with custom React element (if present)

src/index.ts

@@ -21,7 +21,7 @@ const domParserOptions = { lowerCaseAttributeNames: false } as const;
 export default function HTMLReactParser(
   html: string,
   options?: HTMLReactParserOptions,
-): JSX.Element | JSX.Element[] | string {
+): ReturnType<typeof domToReact> {
   if (typeof html !== 'string') {
     throw new TypeError('First argument must be a string');
   }