Integration tests for origin heuristics #11620
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
…t-origin-heuristics
aedm
added
the
exclude from changelog
emilk
approved these changes
Nov 4, 2025
Comment on lines
+10
to
+16
| fn make_test_image() -> re_types::archetypes::Image { | ||
| let image = ndarray::Array3::from_shape_fn((256, 256, 3), |(y, x, c)| match c { | ||
| 0 => x as u8, | ||
| 1 => y as u8, | ||
| 2 => 128, | ||
| _ => unreachable!(), | ||
| }); |
Comment on lines
+139
to
+142
| // Close the selection panel before clicking on the image entity | ||
| // because rendering its download button requires the UI to be on | ||
| // the main thread. We are in a tokio test and it will crash. | ||
| harness.set_selection_panel_opened(false); |
Member
There was a problem hiding this comment.
What is this about? Is this related to MainThreadToken? Do we really need to be on main thread to render the button? I would assume we would only need it to process the save-action (i.e. handle clicking it)!
What happens if you remove this line? Does something crash?
| @@ -0,0 +1,246 @@ | |||
| use egui_kittest::kittest::Queryable as _; | |||
Member
There was a problem hiding this comment.
Should have a module-level comment explaining roughly what this test is all about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Part of #8948
What
check_context_menu_suggested_origin.pyfrom release checklist