-
Notifications
You must be signed in to change notification settings - Fork 584
Auth for Jupyter Notebooks #11855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth for Jupyter Notebooks #11855
Conversation
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
jprochazk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, nice work!
I'm not totally sure about the refresh mechanism.
The refresh token may only be used once. There is no coordination between different Viewer instances on which one should refresh the credentials. So if the access token expires, and all the Viewers are using it, they will all try to refresh simultaneously (though serialized due to single-threaded nature of JS/Wasm).
I believe the kernel should be refreshing the credentials before constructing any Viewer. And the Viewers should only receive the access token, not a refresh token, so that they don't try to refresh credentials.
That makes sense. Good idea! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A few more nitpicks. Please also fix the lints before you merge.
Related
Related to https://linear.app/rerun/issue/RR-2861/authentication-in-jupyter-notebooks
What
Implements authentication in Jupyter notebooks.
rr.login()the user can log in.re_authmodule, starts a web server in the background to listen to events.