Correct toolbars visibility management

Author: sendevent

ReText/config.py

@@ -223,7 +223,10 @@ def getPageWidget(self, options):
             elif name == 'directoryPath':
                 self.configurators[name] = DirectorySelectButton(self, value, fileLabel)
             elif name == 'hideToolBar':
+                # A label that has been created but not yet laid out could remain visible even after its reference has been dropped
+                label.setParent(None)
                 label = None
+
                 gb = QGroupBox("Toolbars")
                 gb.setCheckable(True)
                 gb.setChecked(not globalSettings.hideToolBar)

ReText/window.py

@@ -1463,11 +1463,5 @@ def manage_toolbars_visibility(self):
 
         self.toolBar.setVisible(shown and globalSettings.showToolBarFile)
         self.editBar.setVisible(shown and globalSettings.showToolBarEdit)
-
-        if shown:
-            if globalSettings.showToolBarFormat:
-                self.formatBar.setVisible(True)
-                self.formattingBoxAction.setVisible(False)
-            else:
-                self.formatBar.setVisible(False)
-                self.formattingBoxAction.setVisible(True)
+        self.formatBar.setVisible(shown and globalSettings.showToolBarFormat)
+        self.formattingBoxAction.setVisible(shown and not globalSettings.showToolBarFormat)