From 3e687bb25573002e9b87c35a7d60d5e6fe45307f Mon Sep 17 00:00:00 2001 From: Antonio Vieiro Date: Thu, 5 Nov 2026 09:29:58 +0100 Subject: [PATCH 1/2] CheckCerts - Print out names of badroots in exception Signed-off-by: Antonio Vieiro --- test/reproducers/emudra/CheckCerts.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/reproducers/emudra/CheckCerts.java b/test/reproducers/emudra/CheckCerts.java index f9a4564..808b9d8 100644 --- a/test/reproducers/emudra/CheckCerts.java +++ b/test/reproducers/emudra/CheckCerts.java @@ -38,6 +38,7 @@ import javax.net.ssl.*; import java.security.*; import java.security.cert.*; +import java.util.*; import static java.lang.System.out; @@ -65,7 +66,7 @@ public static void main(String ... args) throws Exception { TrustManagerFactory tmf = TrustManagerFactory.getInstance(TrustManagerFactory.getDefaultAlgorithm()); tmf.init((KeyStore)null); - boolean badroots = false; + ArrayList badroots = new ArrayList<>(); for (String r : ROOTS) { for (TrustManager tm : tmf.getTrustManagers()) { @@ -74,15 +75,15 @@ public static void main(String ... args) throws Exception { String nm = cert.getSubjectX500Principal().getName(); if (nm.contains("CN=" + r)) { out.format("BAD ROOT: %s%n", nm); - badroots = true; + badroots.add(nm); } } } } } - if (badroots) - throw new RuntimeException("Found bad roots"); + if (badroots.size() > 0) + throw new RuntimeException(String.format("Found bad roots [%s]", String.join(";", badroots))); else out.format("No bad root certificates found%n"); From 8c3908172e3933a003a0f78a385737da590f68a4 Mon Sep 17 00:00:00 2001 From: Antonio Vieiro Date: Thu, 5 Nov 2026 09:41:18 +0100 Subject: [PATCH 2/2] Added CheckCertsStrict.java Signed-off-by: Antonio Vieiro --- test/reproducers/emudra/CheckCerts.java | 4 ++-- test/reproducers/emudra/CheckCertsStrict.java | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/test/reproducers/emudra/CheckCerts.java b/test/reproducers/emudra/CheckCerts.java index 808b9d8..2039e1e 100644 --- a/test/reproducers/emudra/CheckCerts.java +++ b/test/reproducers/emudra/CheckCerts.java @@ -66,7 +66,7 @@ public static void main(String ... args) throws Exception { TrustManagerFactory tmf = TrustManagerFactory.getInstance(TrustManagerFactory.getDefaultAlgorithm()); tmf.init((KeyStore)null); - ArrayList badroots = new ArrayList<>(); + ArrayList badroots = new ArrayList<>(); for (String r : ROOTS) { for (TrustManager tm : tmf.getTrustManagers()) { @@ -75,7 +75,7 @@ public static void main(String ... args) throws Exception { String nm = cert.getSubjectX500Principal().getName(); if (nm.contains("CN=" + r)) { out.format("BAD ROOT: %s%n", nm); - badroots.add(nm); + badroots.add(nm); } } } diff --git a/test/reproducers/emudra/CheckCertsStrict.java b/test/reproducers/emudra/CheckCertsStrict.java index 7358629..f8d9a38 100644 --- a/test/reproducers/emudra/CheckCertsStrict.java +++ b/test/reproducers/emudra/CheckCertsStrict.java @@ -38,6 +38,7 @@ import javax.net.ssl.*; import java.security.*; import java.security.cert.*; +import java.util.*; import static java.lang.System.out; @@ -64,7 +65,7 @@ public static void main(String ... args) throws Exception { TrustManagerFactory tmf = TrustManagerFactory.getInstance(TrustManagerFactory.getDefaultAlgorithm()); tmf.init((KeyStore)null); - boolean badroots = false; + ArrayList badroots = new ArrayList<>(); for (String r : ROOTS) { for (TrustManager tm : tmf.getTrustManagers()) { @@ -73,15 +74,15 @@ public static void main(String ... args) throws Exception { String nm = cert.getSubjectX500Principal().getName(); if (nm.contains("CN=" + r)) { out.format("BAD ROOT: %s%n", nm); - badroots = true; + badroots.add(nm); } } } } } - if (badroots) - throw new RuntimeException("Found bad roots"); + if (badroots.size() > 0) + throw new RuntimeException(String.format("Found bad roots [%s]", String.join(";", badroots))); else out.format("No bad root certificates found%n");