Unit tests for OptionStringList::get_value_string and to_string

The primary tests call get_value_string, which provides implicit
coverage for the internally called to_string method.

Author: jrohel

test/libdnf5/conf/test_option.cpp

@@ -494,6 +494,34 @@ void OptionTest::test_options_string_list_custom_delimiters() {
     CPPUNIT_ASSERT_EQUAL((std::vector<std::string>{"Dfirstx", "DsecondX"}), option3.get_value());
 }
 
+void OptionTest::test_options_string_list_to_string() {
+    OptionStringList option(std::vector<std::string>{"Dfirstx", "DsecondX"});
+    CPPUNIT_ASSERT_EQUAL(std::string{"Dfirstx,DsecondX"}, option.get_value_string());
+
+    option.set(Option::Priority::RUNTIME, std::vector<std::string>{" ", "DsecondX"});
+    CPPUNIT_ASSERT_EQUAL(std::string{"\\ ,DsecondX"}, option.get_value_string());
+
+    option.set(Option::Priority::RUNTIME, std::vector<std::string>{"asdasd", " ", "DsecondX"});
+    CPPUNIT_ASSERT_EQUAL(std::string{"asdasd,\\ ,DsecondX"}, option.get_value_string());
+
+    option.set(Option::Priority::RUNTIME, std::vector<std::string>{"asdasd", ",", "\\DsecondX"});
+    CPPUNIT_ASSERT_EQUAL(std::string{"asdasd,\\,,\\\\DsecondX"}, option.get_value_string());
+
+    option.set(Option::Priority::RUNTIME, std::vector<std::string>{" asdasd, ", "DsecondX"});
+    CPPUNIT_ASSERT_EQUAL(std::string{"\\ asdasd\\,\\ ,DsecondX"}, option.get_value_string());
+}
+
+void OptionTest::test_options_string_list_custom_delimiters_to_string() {
+    OptionStringList option(std::vector<std::string>{"aa; b", "ccc,"}, "", true, ";");
+    CPPUNIT_ASSERT_EQUAL(std::string{"aa\\; b;ccc,"}, option.get_value_string());
+
+    option.set(Option::Priority::RUNTIME, std::vector<std::string>{"", ";aa; :b", "ccc,"});
+    CPPUNIT_ASSERT_EQUAL(std::string{";\\;aa\\; :b;ccc,"}, option.get_value_string());
+
+    OptionStringList option2(std::vector<std::string>{"", ";a\\a; :b", "ccc,"}, "", true, ";:");
+    CPPUNIT_ASSERT_EQUAL(std::string{";\\;a\\\\a\\; \\:b;ccc,"}, option2.get_value_string());
+}
+
 void OptionTest::test_options_string_set() {
     const OptionStringSet::ValueType initial{"x", "y", "z"};
     OptionStringSet option(initial);

test/libdnf5/conf/test_option.hpp

@@ -37,6 +37,8 @@ class OptionTest : public CppUnit::TestCase {
     CPPUNIT_TEST(test_options_string_list);
     CPPUNIT_TEST(test_options_string_list_delimiters);
     CPPUNIT_TEST(test_options_string_list_custom_delimiters);
+    CPPUNIT_TEST(test_options_string_list_to_string);
+    CPPUNIT_TEST(test_options_string_list_custom_delimiters_to_string);
     CPPUNIT_TEST(test_options_string_set);
     CPPUNIT_TEST(test_options_list_add);
     CPPUNIT_TEST(test_options_list_add_item);
@@ -54,6 +56,8 @@ class OptionTest : public CppUnit::TestCase {
     void test_options_string_list();
     void test_options_string_list_delimiters();
     void test_options_string_list_custom_delimiters();
+    void test_options_string_list_to_string();
+    void test_options_string_list_custom_delimiters_to_string();
     void test_options_string_set();
     void test_options_list_add();
     void test_options_list_add_item();