core: Fix CORS issues with fpdownload.adobe.com
#22168
Open
+175
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all code in Ruffle had to use fetch() directly from the navigator, which made it difficult to implement generic logic around fetch. This patch provides Player::fetch, which can be used for that purpose.
This informs the player about the context around the fetch. It allows the player to know whether the fetch expects a SWF or some other data.
This method is useful for rewriting response URLs in compatibility rules.
kjarosh
added
A-core
kjarosh
changed the title
fpdownload.adobe.comfpdownload.adobe.com
This patch adds UrlRewriteStage which tells at what stage the given URL rewrite should be applied, and does it generically in the common fetch method.
Different compatibility rules need to be applied during different fetches, this allows to discriminate against that.
This domain hosts SWZ files and does not work on web due to CORS. This fixes content that requires those SWZ files and the website owner does not provide them. As a bonus we don't have to worry about reliability of fpdownload.adobe.com and the fact that some day it will stop working.
kjarosh
force-pushed
the
fpdownload-cdn
branch
from
3028299 to
a6c8686
Compare
kjarosh
added
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This domain hosts SWZ files and does not work on web due to CORS. This fixes content that requires those SWZ files and the website owner does not provide them. As a bonus we don't have to worry about reliability of
fpdownload.adobe.comand the fact that some day it will stop working.This needed a bit of refactoring of compatibility rules and fetch.
This PR effectively redirects all URLLoader requests from
fpdownload.adobe.comtocdn.ruffle.rswhich is set up with all SWZs we could find on the Wayback machine. Apparently they include all SWZs used on Flashpoint, so it's a pretty big collection.