Size constants are confusingly named

[TheBlueMatt]

We were going through to use secp256k1's size constants, but they're pretty confusing in their naming. eg PUBLIC_KEY_SIZE isn't really the "size" of a public key (in memory or conceptually), but rather the size of a public key when serialized in compressed form. Similarly, MAX_SIGNATURE_SIZE isn't actually the maximum signature size, but rather the maximum signature size the libsecp will generate (and the maximum standard signature size in Bitcoin), but some downstream logic will probably also grind signatures to reduce the max size but a further one.

[apoelstra]

These are the "size" of objects when they're encoded on the wire.

Do you have suggestions for better names?

[TheBlueMatt]

Maybe COMPRESSED_PUBLIC_KEY_SIZE and MAX_GENERATED_SIGNATURE_SIZE (for these two specifically)?

[apoelstra]

Yep, I like those.

[tcharding]

If we deprecate the old ones and add the new ones we could push this into another RC release then it will get into the imminent bitcoin RC release?

[apoelstra]

I dunno if it's really worth deprecating these. I'm surprised to hear that anybody was using them. They are sorta internal constants used for array sizing etc. (Though I argued against adding them because I felt they were "obvious" and was overruled.)