Skip to content

gui-tests: explicitly install chrome in docker image, fix lint-js #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuillaumeGomez merged 2 commits into from
May 22, 2026
Merged

gui-tests: explicitly install chrome in docker image, fix lint-js #3347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5452d9e
gui-tests: install chromium inside docker image to fix test
syphar May 22, 2026
1217e6b
freeze deno version to fix lint-js
syphar May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ jobs:
- uses: actions/checkout@v6

- uses: denoland/setup-deno@v2
with:
deno-version: v2.7.14

- uses: taiki-e/install-action@v2
with:
Expand Down
3 changes: 3 additions & 0 deletions dockerfiles/Dockerfile-gui-tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ RUN apt-get install -y --no-install-recommends \
libasound2 \
libatk1.0-0 \
libatk-bridge2.0-0 \
chromium \
libc6 \
libcairo2 \
libcups2 \
Expand Down Expand Up @@ -68,6 +69,8 @@ RUN mkdir out

COPY ../package.json /build/package.json

ENV PUPPETEER_EXECUTABLE_PATH=/usr/bin/chromium

# For now, we need to use `--unsafe-perm=true` to go around an issue when npm tries
# to create a new folder. For reference:
# https://github.com/puppeteer/puppeteer/issues/375
Expand Down
Loading