From cefe4cc13401b1d28a4a236bceb047d2fd51ff4b Mon Sep 17 00:00:00 2001 From: shulaoda <165626830+shulaoda@users.noreply.github.com> Date: Sat, 23 May 2026 06:21:12 +0800 Subject: [PATCH] refactor: apply clippy::needless_borrow --- src/chains.rs | 4 ++-- src/expr.rs | 2 +- src/format_report_formatter.rs | 2 +- src/items.rs | 6 +++--- src/macros.rs | 4 ++-- src/overflow.rs | 2 +- src/sort.rs | 2 +- src/types.rs | 6 +++--- 8 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/chains.rs b/src/chains.rs index 90adb67ad43..db93a9be8bf 100644 --- a/src/chains.rs +++ b/src/chains.rs @@ -300,7 +300,7 @@ impl Rewrite for ChainItem { ChainItemKind::Parent { ref expr, parens: true, - } => crate::expr::rewrite_paren(context, &expr, shape, expr.span)?, + } => crate::expr::rewrite_paren(context, expr, shape, expr.span)?, ChainItemKind::Parent { ref expr, parens: false, @@ -367,7 +367,7 @@ impl ChainItem { format!("::<{}>", type_list.join(", ")) }; let callee_str = format!(".{}{}", rewrite_ident(context, method_name), type_str); - rewrite_call(context, &callee_str, &args, span, shape) + rewrite_call(context, &callee_str, args, span, shape) } } diff --git a/src/expr.rs b/src/expr.rs index b79137c4442..722a7c69f96 100644 --- a/src/expr.rs +++ b/src/expr.rs @@ -2321,7 +2321,7 @@ fn choose_rhs( match (orig_rhs, new_rhs) { (Ok(ref orig_rhs), Ok(ref new_rhs)) - if !filtered_str_fits(&new_rhs, context.config.max_width(), new_shape) => + if !filtered_str_fits(new_rhs, context.config.max_width(), new_shape) => { Ok(format!("{before_space_str}{orig_rhs}")) } diff --git a/src/format_report_formatter.rs b/src/format_report_formatter.rs index 08889c712a5..059484ee8db 100644 --- a/src/format_report_formatter.rs +++ b/src/format_report_formatter.rs @@ -65,7 +65,7 @@ impl<'a> Display for FormatReportFormatter<'a> { let message_suffix = error.msg_suffix(); if !message_suffix.is_empty() { - message = message.footer(Level::Note.title(&message_suffix)); + message = message.footer(Level::Note.title(message_suffix)); } let origin = format!("{}:{}", file, error.line); diff --git a/src/items.rs b/src/items.rs index a2c0e8e0f50..3ec9d8c32f6 100644 --- a/src/items.rs +++ b/src/items.rs @@ -1859,7 +1859,7 @@ fn rewrite_ty( let option = WhereClauseOption::new(true, WhereClauseSpace::Newline); let after_where_clause_str = rewrite_where_clause( context, - &after_where_clause, + after_where_clause, context.config.brace_style(), Shape::indented(indent, context.config), false, @@ -2489,7 +2489,7 @@ fn rewrite_fn_base( let generics_str = rewrite_generics( context, rewrite_ident(context, ident), - &fn_sig.generics, + fn_sig.generics, shape, )?; result.push_str(&generics_str); @@ -2734,7 +2734,7 @@ fn rewrite_fn_base( } let where_clause_str = rewrite_where_clause( context, - &where_clause, + where_clause, context.config.brace_style(), Shape::indented(indent, context.config), true, diff --git a/src/macros.rs b/src/macros.rs index 2d56021069c..4b8b548e0ae 100644 --- a/src/macros.rs +++ b/src/macros.rs @@ -822,7 +822,7 @@ impl MacroArgParser { // Parse '*', '+' or '?. for tok in iter { - self.set_last_tok(&tok); + self.set_last_tok(tok); if first { first = false; } @@ -970,7 +970,7 @@ impl MacroArgParser { } } - self.set_last_tok(&tok); + self.set_last_tok(tok); } // We are left with some stuff in the buffer. Since there is nothing diff --git a/src/overflow.rs b/src/overflow.rs index 4230c89b57b..4589d8a0c7e 100644 --- a/src/overflow.rs +++ b/src/overflow.rs @@ -584,7 +584,7 @@ impl<'a> Context<'a> { if tactic == DefinitiveListTactic::Vertical { if let Some((all_simple, num_args_before)) = - maybe_get_args_offset(self.ident, &self.items, &self.context.config) + maybe_get_args_offset(self.ident, &self.items, self.context.config) { let one_line = all_simple && definitive_tactic( diff --git a/src/sort.rs b/src/sort.rs index 0cdd937b4f5..ef3b31c9a6f 100644 --- a/src/sort.rs +++ b/src/sort.rs @@ -151,7 +151,7 @@ pub(crate) fn version_sort(a: &str, b: &str) -> std::cmp::Ordering { (VersionChunk::Str(ca), VersionChunk::Str(cb)) | (VersionChunk::Str(ca), VersionChunk::Number { source: cb, .. }) | (VersionChunk::Number { source: ca, .. }, VersionChunk::Str(cb)) => { - match ca.cmp(&cb) { + match ca.cmp(cb) { std::cmp::Ordering::Equal => { continue; } diff --git a/src/types.rs b/src/types.rs index 94ed42c6ea5..6aeca039022 100644 --- a/src/types.rs +++ b/src/types.rs @@ -499,14 +499,14 @@ impl Rewrite for ast::WherePredicate { let mut result = String::with_capacity(attrs_str.len() + pred_str.len() + 1); result.push_str(&attrs_str); let pred_start = self.span.lo(); - let line_len = last_line_width(&attrs_str) + 1 + first_line_width(&pred_str); + let line_len = last_line_width(&attrs_str) + 1 + first_line_width(pred_str); if let Some(last_attr) = self.attrs.last().filter(|last_attr| { contains_comment(context.snippet(mk_sp(last_attr.span.hi(), pred_start))) }) { result = combine_strs_with_missing_comments( context, &result, - &pred_str, + pred_str, mk_sp(last_attr.span.hi(), pred_start), Shape { width: shape.width.min(context.config.inline_attribute_width()), @@ -525,7 +525,7 @@ impl Rewrite for ast::WherePredicate { result.push(' '); } } - result.push_str(&pred_str); + result.push_str(pred_str); } Ok(result)