Added CREATED status for new vulnerability (#2840)

* Added CREATED status for new vulnerability

Author: Cheshiriks

save-backend/src/main/kotlin/com/saveourtool/save/backend/controllers/vulnerability/event/VulnerabilityMetadataListener.kt

@@ -23,7 +23,7 @@ class VulnerabilityMetadataListener(
      */
     @EventListener
     fun createVulnerabilityMetadata(vulnerabilityEvent: VulnerabilityMetadataEvent) {
-        if (vulnerabilityEvent.vulnerabilityMetadata.status == VulnerabilityStatus.PENDING_REVIEW) {
+        if (vulnerabilityEvent.vulnerabilityMetadata.status == VulnerabilityStatus.CREATED) {
             val recipients = userDetailsService.findByRole(Role.SUPER_ADMIN.asSpringSecurityRole())
             val notifications = recipients.map {
                 Notification(

save-backend/src/main/kotlin/com/saveourtool/save/backend/security/VulnerabilityPermissionEvaluator.kt

@@ -39,7 +39,8 @@ class VulnerabilityPermissionEvaluator(
         return when {
             authentication.hasRole(Role.SUPER_ADMIN) -> true
             permission == Permission.READ -> true
-            permission == Permission.DELETE -> vulnerability.status == VulnerabilityStatus.PENDING_REVIEW && hasFullPermission(vulnerability, authentication)
+            permission == Permission.DELETE -> (vulnerability.status == VulnerabilityStatus.CREATED || vulnerability.status == VulnerabilityStatus.PENDING_REVIEW) &&
+                    hasFullPermission(vulnerability, authentication)
             else -> hasFullPermission(vulnerability, authentication)
         }
     }

save-cloud-common/src/commonMain/kotlin/com/saveourtool/save/entities/vulnerability/VulnerabilityStatus.kt

@@ -20,6 +20,11 @@ enum class VulnerabilityStatus {
      */
     AUTO_APPROVED,
 
+    /**
+     * Created status
+     */
+    CREATED,
+
     /**
      * Review status
      */

save-cosv/src/main/kotlin/com/saveourtool/save/cosv/service/VulnerabilityMetadataService.kt

@@ -63,10 +63,9 @@ class VulnerabilityMetadataService(
                 existedMetadata.updateBy(cosv, cosvFile, isAutoApprove)
             }
             ?: run {
-                val newMetadata = cosv.toNewMetadata(user, organization, cosvFile, isAutoApprove)
-                applicationEventPublisher.publishEvent(VulnerabilityMetadataEvent(newMetadata))
-                newMetadata
+                cosv.toNewMetadata(user, organization, cosvFile, isAutoApprove)
             }
+        applicationEventPublisher.publishEvent(VulnerabilityMetadataEvent(metadata))
 
         return vulnerabilityMetadataRepository.save(metadata)
     }
@@ -103,7 +102,7 @@ class VulnerabilityMetadataService(
             user = user,
             organization = organization,
             language = getLanguage() ?: VulnerabilityLanguage.OTHER,
-            status = isAutoApprove.toVulnerabilityStatus(),
+            status = toVulnerabilityStatus(isAutoApprove, true),
             latestCosvFile = cosvFile,
         )
 
@@ -162,7 +161,7 @@ class VulnerabilityMetadataService(
             severityNum = entry.getSeverityNumber()
             modified = entry.modified.toJavaLocalDateTime()
             latestCosvFile = cosvFile
-            status = isAutoApprove.toVulnerabilityStatus()
+            status = toVulnerabilityStatus(isAutoApprove, false)
         }
 
         private fun CosvSchema<*, *, *, *>.getSeverityNumber() =
@@ -172,6 +171,12 @@ class VulnerabilityMetadataService(
                     getScore(it)
                 } ?: 0f
 
-        private fun Boolean.toVulnerabilityStatus() = if (this) VulnerabilityStatus.AUTO_APPROVED else VulnerabilityStatus.PENDING_REVIEW
+        private fun toVulnerabilityStatus(isAutoApprove: Boolean, isNew: Boolean) = if (isAutoApprove) {
+            VulnerabilityStatus.AUTO_APPROVED
+        } else if (isNew) {
+            VulnerabilityStatus.CREATED
+        } else {
+            VulnerabilityStatus.PENDING_REVIEW
+        }
     }
 }

save-frontend/src/main/kotlin/com/saveourtool/save/frontend/components/views/vuln/VulnerabilityCollectionView.kt

@@ -325,7 +325,7 @@ private fun getFiltersByTab(
         setIsOwnerTab(false)
         VulnerabilityFilter(
             identifierPrefix = "",
-            statuses = listOf(VulnerabilityStatus.PENDING_REVIEW),
+            statuses = listOf(VulnerabilityStatus.CREATED, VulnerabilityStatus.PENDING_REVIEW),
         )
     }
     VulnerabilityListTab.OWNER -> {

save-frontend/src/main/kotlin/com/saveourtool/save/frontend/components/views/vuln/VulnerabilityHeader.kt

@@ -281,7 +281,9 @@ internal val headerMenu: FC<HeaderMenuProps> = FC { props ->
                         }
                     }
 
-                    if (props.permissions.isSuperAdmin && props.vulnerability.metadataDto.status == VulnerabilityStatus.PENDING_REVIEW) {
+                    if (props.permissions.isSuperAdmin && props.vulnerability.metadataDto.status.let {
+                        it == VulnerabilityStatus.CREATED || it == VulnerabilityStatus.PENDING_REVIEW
+                    }) {
                         buttonBuilder(label = "Approve".t(), classes = "mr-2 btn-sm", style = "success") {
                             enrollUpdateRequest()
                         }