Skip to content

Commit 21e1c87

Browse files
Hotfix/make job start time nullable (#46)
* Make startTime and endTime fields optional in Job type and GraphQL schema * Display 'N/A' for missing startTime and endTime in Job detail components
1 parent b5eacc4 commit 21e1c87

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

components/ui/graphql/src/generated/schema.graphql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,15 +149,15 @@ type Job {
149149
dockerComputeResourceContextUUID: UUID
150150
dockerImageName: String!
151151
duration: Float!
152-
endTime: DateTime!
152+
endTime: DateTime
153153
executorDID: String
154154
fullDockerCommand: [String!]!
155155
id: ID!
156156
messages: [JobMessage!]!
157157
resultsFolderURI: String!
158158
runByUUID: String
159159
scriptURI: String
160-
startTime: DateTime!
160+
startTime: DateTime
161161
status: JobStatus!
162162
submissionTime: DateTime!
163163
submitterDID: String!

components/ui/graphql/src/generated/typings.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,15 +178,15 @@ export type Job = {
178178
dockerComputeResourceContextUUID?: Maybe<Scalars['UUID']>;
179179
dockerImageName: Scalars['String'];
180180
duration: Scalars['Float'];
181-
endTime: Scalars['DateTime'];
181+
endTime?: Maybe<Scalars['DateTime']>;
182182
executorDID?: Maybe<Scalars['String']>;
183183
fullDockerCommand: Array<Scalars['String']>;
184184
id: Scalars['ID'];
185185
messages: Array<JobMessage>;
186186
resultsFolderURI: Scalars['String'];
187187
runByUUID?: Maybe<Scalars['String']>;
188188
scriptURI?: Maybe<Scalars['String']>;
189-
startTime: Scalars['DateTime'];
189+
startTime?: Maybe<Scalars['DateTime']>;
190190
status: JobStatus;
191191
submissionTime: Scalars['DateTime'];
192192
submitterDID: Scalars['String'];
@@ -675,15 +675,15 @@ export type JobResolvers<ContextType = Context, ParentType extends ResolversPare
675675
dockerComputeResourceContextUUID?: Resolver<Maybe<ResolversTypes['UUID']>, ParentType, ContextType>;
676676
dockerImageName?: Resolver<ResolversTypes['String'], ParentType, ContextType>;
677677
duration?: Resolver<ResolversTypes['Float'], ParentType, ContextType>;
678-
endTime?: Resolver<ResolversTypes['DateTime'], ParentType, ContextType>;
678+
endTime?: Resolver<Maybe<ResolversTypes['DateTime']>, ParentType, ContextType>;
679679
executorDID?: Resolver<Maybe<ResolversTypes['String']>, ParentType, ContextType>;
680680
fullDockerCommand?: Resolver<Array<ResolversTypes['String']>, ParentType, ContextType>;
681681
id?: Resolver<ResolversTypes['ID'], ParentType, ContextType>;
682682
messages?: Resolver<Array<ResolversTypes['JobMessage']>, ParentType, ContextType>;
683683
resultsFolderURI?: Resolver<ResolversTypes['String'], ParentType, ContextType>;
684684
runByUUID?: Resolver<Maybe<ResolversTypes['String']>, ParentType, ContextType>;
685685
scriptURI?: Resolver<Maybe<ResolversTypes['String']>, ParentType, ContextType>;
686-
startTime?: Resolver<ResolversTypes['DateTime'], ParentType, ContextType>;
686+
startTime?: Resolver<Maybe<ResolversTypes['DateTime']>, ParentType, ContextType>;
687687
status?: Resolver<ResolversTypes['JobStatus'], ParentType, ContextType>;
688688
submissionTime?: Resolver<ResolversTypes['DateTime'], ParentType, ContextType>;
689689
submitterDID?: Resolver<ResolversTypes['String'], ParentType, ContextType>;

components/ui/graphql/src/types/jobs.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ export const typeDefs = gql`
2222
id: ID!
2323
submitterDID: String!
2424
submissionTime: DateTime!
25-
startTime: DateTime!
26-
endTime: DateTime!
2725
duration: Float!
2826
messages: [JobMessage!]!
2927
status: JobStatus!
@@ -35,6 +33,8 @@ export const typeDefs = gql`
3533
dockerComputeEndpoint: String!
3634
dockerImageName: String!
3735
fullDockerCommand: [String!]!
36+
startTime: DateTime
37+
endTime: DateTime
3838
runByUUID: String
3939
timeout: Int
4040
dockerComputeResourceContextUUID: UUID

components/ui/web/components/content/jobs/detail/jobFullDetail.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,15 +196,15 @@ export const JobFullDetail: FC<Props> = ({ job, back }) => {
196196
Started:
197197
</Typography>
198198
<Typography variant="body1" gutterBottom component="div">
199-
{new Date(job.startTime).toLocaleString()}
199+
{job.startTime ? new Date(job.startTime).toLocaleString() : 'N/A'}
200200
</Typography>
201201
</div>
202202
<div className="job-field">
203203
<Typography variant="h5" gutterBottom component="div">
204204
Ended:
205205
</Typography>
206206
<Typography variant="body1" gutterBottom component="div">
207-
{new Date(job.endTime).toLocaleString()}
207+
{job.endTime ? new Date(job.endTime).toLocaleString() : 'N/A'}
208208
</Typography>
209209
</div>
210210
</div>

components/ui/web/components/content/jobs/detail/jobShortDetail.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,15 +92,15 @@ export const JobShortDetail: FC<Props> = ({ job, isOpen, selectJob }) => {
9292
Started:
9393
</Typography>
9494
<Typography variant="body1" gutterBottom component="div">
95-
{new Date(job.startTime).toLocaleString()}
95+
{job.startTime ? new Date(job.startTime).toLocaleString() : 'N/A'}
9696
</Typography>
9797
</div>
9898
<div className="job-field">
9999
<Typography variant="h5" gutterBottom component="div">
100100
Ended:
101101
</Typography>
102102
<Typography variant="body1" gutterBottom component="div">
103-
{new Date(job.endTime).toLocaleString()}
103+
{job.endTime ? new Date(job.endTime).toLocaleString() : 'N/A'}
104104
</Typography>
105105
</div>
106106
</div>

0 commit comments

Comments
 (0)