feature: affect commit status(es) via meta

[drewfish]

What you expected to happen:
I'd be nice if there were some kind of special meta keys which when set would become "commit checks" for github commits (especially for PRs).

[drewfish]

(This is similar to #1355, but is for tweaking the commit checks (instead of posting comments).)

[jithine]

These status can also be actual build steps. If we provide a hook to mark the step itself as, say Unstable but continue with rest of steps, will that suffice ?

[drewfish]

That's less than ideal. It's quite handy if the github PR page has a list of "checks", each of which either passes or fails.

[jithine]

I propose we use a syntax like this

meta.status.key = {
  status: success/failure,
  url: https://coveralls.io/builds/buildID || Screwdriver build LInk
  description: "",
  context: ""
}

Reference - https://developer.github.com/v3/repos/statuses/#create-a-status

[drewfish]

would/could the url parameter be autogenerated by whatever part of the SD system (or plugin) posts back to github? or perhaps would it be easy to generate (using SD_BUILD_URL or something like that)?

[jithine]

would/could the url parameter be autogenerated by whatever part of the SD system (or plugin) posts back to github? or perhaps would it be easy to generate (using SD_BUILD_URL or something like that)?

yes, if user has not set anything, then SD will default it to build link, but user/plugin choose to then they can set something which is specific to the status. Let's say this is for a step which uses FOSSA scanner, then URL can simple point to the relevant link in FOSSA server. Same can de done for SonarQube, if there are quality gates setup for a project.

[tkyi]

Tested it out in prod: tkyi/mytest#37
Documentation at the bottom of this page: https://docs.screwdriver.cd/user-guide/metadata