Skip to content

Commit 0ede0cd

Browse files
authored
feat(blob-uploader): upload blob once proposed (#1759)
Co-authored-by: yiweichi <[email protected]>
1 parent 9dceae1 commit 0ede0cd

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

common/version/version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55
"runtime/debug"
66
)
77

8-
var tag = "v4.7.1"
8+
var tag = "v4.7.2"
99

1010
var commit = func() string {
1111
if info, ok := debug.ReadBuildInfo(); ok {

rollup/internal/controller/blob_uploader/blob_uploader.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -242,10 +242,12 @@ func (b *BlobUploader) GetFirstUnuploadedBatchByPlatform(ctx context.Context, st
242242
break
243243
}
244244

245-
if len(batch.CommitTxHash) == 0 {
246-
log.Debug("got batch not committed for blob uploading", "batch_index", batchIndex, "platform", platform.String())
247-
return nil, nil
248-
}
245+
// disable this check to upload blobs before it's committed. This is to
246+
// alleviate the case nodes try to fetch the blob from s3 before its uploaded.
247+
// if len(batch.CommitTxHash) == 0 {
248+
// log.Debug("got batch not committed for blob uploading", "batch_index", batchIndex, "platform", platform.String())
249+
// return nil, nil
250+
// }
249251

250252
return batch, nil
251253
}

0 commit comments

Comments
 (0)