Skip to content

Add blake2b hashing support#4

Merged
bennettgoble merged 1 commit intosecondlife:mainfrom
RyeMutt:blake2b
Sep 28, 2022
Merged

Add blake2b hashing support#4
bennettgoble merged 1 commit intosecondlife:mainfrom
RyeMutt:blake2b

Conversation

@RyeMutt
Copy link
Copy Markdown
Contributor

@RyeMutt RyeMutt commented Sep 28, 2022

This add supports for blake2b hashing to packages as well as a new field to the results dict

Comment thread autobuild/hash_algorithms.py Outdated
@bennettgoble
Copy link
Copy Markdown

bennettgoble commented Sep 28, 2022

Thanks for the PR, @RyeMutt. These changes look good: one style nit to patch and I'd be happy to have it merged.

Edit: will need to patch up the tests as well.

@RyeMutt RyeMutt force-pushed the blake2b branch 3 times, most recently from ce2734a to 8c222ed Compare September 28, 2022 00:30
Copy link
Copy Markdown

@bennettgoble bennettgoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@bennettgoble bennettgoble added the enhancement New feature or request label Sep 28, 2022
@bennettgoble bennettgoble merged commit 4e63112 into secondlife:main Sep 28, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@25e0050). Learn more about missing BASE report.

Files with missing lines Patch % Lines
autobuild/common.py 80.00% 2 Missing ⚠️
autobuild/hash_algorithms.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage        ?   71.22%           
=======================================
  Files           ?       22           
  Lines           ?     3100           
  Branches        ?        0           
=======================================
  Hits            ?     2208           
  Misses          ?      892           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants