add NMEA $PAIR support

Author: semuadmin

INSTALLATION.md

@@ -26,7 +26,7 @@ Though by no means mandatory, it is [generally considered best practice](https:/
 1. Use different versions of the same package across applications.
 1. Keep your application dependencies clean and organized.
 
-Some platforms (e.g. Ubuntu Linux) **enforce** the use of virtual environments via a so-called 'Externally Managed Environment' constraint². Attempting to install a package into the global environment will result in an `error: externally-managed-environment` error.
+Some platforms (e.g. Ubuntu Linux and Homebrew-installed Python environments) **enforce** the use of virtual environments via a so-called 'Externally Managed Environment' constraint². Attempting to install a package into the global environment will result in an `error: externally-managed-environment` error.
 
 ¹ In practice, 'global' generally means the user's home environment. Installing into the platform's global system environment typically results in a `Defaulting to user installation because normal site-packages is not writeable` warning.
 

RELEASE_NOTES.md

@@ -7,6 +7,7 @@ FIXES:
 1. Fix Chart update issue #210
 2. Fix Exit button not invoking on_exit() clean up routines (causing any in-progress GPX track recording to be unterminated).
 3. Fix `IndexError` when loading GPX tracks with no `<time></time>` elements - a synthetic timestamp sequence wil be used instead.
+4. Fix incorrect type formatting for some NMEA commands in NMEA Dynamic Configuration panel.
 
 ENHANCEMENTS:
 
@@ -25,7 +26,9 @@ ENHANCEMENTS:
    On Linux platforms which do not support sqlite3 extensions out of the box, it may be possible to compile from source a  suitable version of [Python](https://github.com/semuconsulting/PyGPSClient/blob/master/examples/python_compile.sh) and/or [libspatialite](https://github.com/semuconsulting/PyGPSClient/blob/master/examples/libspatialite_compile.sh).
 2. BSD 3-Clause license attribution clarified in all modules.
 3. Enhance elevation profile and metadata rendering in GPX track viewer. Add support for route and waypoint elements in addition to track.
-4. Various minor improvements to file exception handling.
+4. Enhance NMEA Dynamic Configuration dialog to support additional NMEA command types, including Quectel proprietary $PAIR  (Quectel LC29H/LC79H), Garmin $PGRM, Locosys %PINV (limited) and u-Blox $PUBX (requires pynmeagps>=1.0.53).
+5. Add support 
+5. Various minor improvements to file exception handling.
 
 ### RELEASE 1.5.13
 

src/pygpsclient/dynamic_config_frame.py

@@ -17,6 +17,7 @@
 """
 
 import logging
+import traceback
 from tkinter import (
     ALL,
     END,
@@ -38,7 +39,12 @@
 )
 
 from PIL import Image, ImageTk
-from pynmeagps import NMEA_PAYLOADS_POLL_PROP, NMEA_PAYLOADS_SET_PROP, NMEAMessage
+from pynmeagps import (
+    NMEA_MSGIDS_PROP,
+    NMEA_PAYLOADS_POLL_PROP,
+    NMEA_PAYLOADS_SET_PROP,
+    NMEAMessage,
+)
 from pyubx2 import (
     POLL,
     SET,
@@ -79,6 +85,7 @@
 
 # following CFG types excluded from selection...
 CFG_EXCLUDED = (
+    "LSC",  # Locosys - many variants not implemented
     "CFG-DAT-NUM",  # deprecated
     "CFG-GEOFENCE",  # 'variable by size' groups not yet implemented - use pyubx2
     "CFG-NMEAv0",  # deprecated
@@ -194,7 +201,7 @@ def _body(self):
             command=self._on_refresh,
             font=self.__app.font_md,
         )
-        self._lbl_command = Label(self, text="", anchor=W)
+        self._lbl_command = Label(self, text="", width=30, anchor=W)
         self._frm_container = Frame(self)
         self._can_container = Canvas(self._frm_container)
         self._frm_attrs = Frame(self._can_container)
@@ -258,7 +265,7 @@ def reset(self):
         self._lbx_cfg_cmd.delete(0, END)
         if self._protocol == NMEA:
             for i, cmd in enumerate(NMEA_PAYLOADS_SET_PROP):
-                if cmd[0:3] == "QTM" and cmd not in CFG_EXCLUDED:
+                if cmd not in CFG_EXCLUDED:
                     self._lbx_cfg_cmd.insert(i, cmd)
         else:
             for i, cmd in enumerate(UBX_PAYLOADS_SET):
@@ -296,11 +303,15 @@ def _on_select_cfg(self, *args, **kwargs):  # pylint: disable=unused-argument
         self._expected_response = None
         idx = self._lbx_cfg_cmd.curselection()
         self._cfg_id = self._lbx_cfg_cmd.get(idx)
-        self._lbl_command.config(text=self._cfg_id)
         if self._protocol == NMEA:
+            cfgid = self._cfg_id.rsplit("_", 1)[0]
+            pde = NMEA_MSGIDS_PROP[cfgid].replace("Sets/Gets", "")
+            pdesc = f"{cfgid} {pde}"
             pdic = NMEA_PAYLOADS_SET_PROP[self._cfg_id]
         else:  # UBX
+            pdesc = self._cfg_id
             pdic = UBX_PAYLOADS_SET[self._cfg_id]
+        self._lbl_command.config(text=f"{pdesc}")
         self._clear_widgets()
         self._add_widgets(pdic, 1, 0)
         self.update()
@@ -330,6 +341,8 @@ def _on_set_cfg(self, *args, **kwargs):  # pylint: disable=unused-argument
                 # strip off any variant suffix from cfg_id
                 # e.g. "QTMCFGUART_CURR" -> "QTMCFGUART"
                 cfg_id = self._cfg_id.rsplit("_", 1)[0]
+                if cfg_id[0:3] == "UBX":  # strip id from msgId
+                    cfg_id = cfg_id[0:3]
                 msg = NMEAMessage("P", cfg_id, SET, **vals)
                 penddlg = NMEA_CFGOTHER
                 pendcfg = ("P" + cfg_id,)
@@ -341,7 +354,7 @@ def _on_set_cfg(self, *args, **kwargs):  # pylint: disable=unused-argument
 
             # send message, update status and await response
             self.__container.send_command(msg)
-            # self.logger.debug(f"command {msg.serialize()}")
+            self.logger.debug(f"command {msg.serialize()}")
             self._lbl_send_command.config(image=self._img_pending)
             self.__container.set_status(
                 f"{self._cfg_id} SET message sent",
@@ -351,6 +364,7 @@ def _on_set_cfg(self, *args, **kwargs):  # pylint: disable=unused-argument
             self._expected_response = SET
 
         except ValueError as err:
+            self.logger.debug(traceback.format_exc())
             self.__container.set_status(
                 f"INVALID! {nam}, {att}: {err}",
                 ERRCOL,

src/pygpsclient/helpers.py

@@ -1127,7 +1127,13 @@ def stringvar2val(val: str, att: str) -> object:
     :rtype: object (int, float or bytes)
     """
 
-    if atttyp(att) in ("E", "I", "L", "U"):  # integer
+    if att in ("DE", "LA", "LN"):  # NMEA float
+        val = float(val)
+    elif att in ("CH", "DT", "HX", "LAD", "LND", "TM"):  # NMEA str, hex
+        pass
+    elif att == "IN":  # NMEA int
+        val = int(val)
+    elif atttyp(att) in ("E", "I", "L", "U"):  # integer
         if val.find(".") != -1:  # ignore scaling decimals
             val = val[0 : val.find(".")]
         val = int(val)
@@ -1141,10 +1147,6 @@ def stringvar2val(val: str, att: str) -> object:
         val = bytes(val, "utf-8")
     elif atttyp(att) == "R":  # float
         val = float(val)
-    elif atttyp(att) in ("IN", "HX"):  # NMEA int
-        val = int(val)
-    elif atttyp(att) in ("DE", "LA", "LN"):  # NMEA float
-        val = float(val)
 
     return val
 

src/pygpsclient/map_canvas.py

@@ -604,7 +604,7 @@ def zoom_bounds(
         """
 
         if location is None:
-            return
+            return None
         xoff = 90 / 2**zoom
         yoff = xoff * height / width
         return Area(