Skip to content

Commit 30f6ebb

Browse files
committed
Wait timeouttest refinement
1 parent eef3bed commit 30f6ebb

1 file changed

Lines changed: 2 additions & 22 deletions

File tree

impl/test/src/test/java/io/serverlessworkflow/impl/test/WaitExecutorTest.java

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ static void tearDown() {
5555
// ========== DurationInline Tests ==========
5656

5757
@Test
58-
@Disabled("This one slow down")
58+
@Disabled("Seconds is too slow and is already covered")
5959
void testWaitWithDurationInlineSeconds() {
6060
Workflow workflow =
6161
WorkflowBuilder.workflow("wait-inline-seconds", "test", "0.1.0")
@@ -87,7 +87,6 @@ void testWaitWithDurationInlineMilliseconds() {
8787

8888
@Test
8989
void testWaitWithDurationInlineComposite() {
90-
// Test composite duration with multiple components
9190
Workflow workflow =
9291
WorkflowBuilder.workflow("wait-inline-composite", "test", "0.1.0")
9392
.tasks(DSL.wait(Duration.ofMillis(100).plusMillis(100)))
@@ -98,7 +97,7 @@ void testWaitWithDurationInlineComposite() {
9897
long elapsed = System.currentTimeMillis() - startTime;
9998

10099
assertThat(model).isNotNull();
101-
assertThat(elapsed).isGreaterThanOrEqualTo(200); // 1 second + 500 milliseconds
100+
assertThat(elapsed).isGreaterThanOrEqualTo(200);
102101
}
103102

104103
// ========== DurationLiteral Tests (TimeoutAfter.durationLiteral) ==========
@@ -122,25 +121,6 @@ void testWaitWithDurationLiteralISO8601Seconds() {
122121
assertThat(elapsed).isGreaterThanOrEqualTo(1000);
123122
}
124123

125-
@Test
126-
void testWaitWithDurationLiteralISO8601Composite() {
127-
Workflow workflow =
128-
WorkflowBuilder.workflow("wait-literal-composite", "test", "0.1.0")
129-
.tasks(
130-
list ->
131-
list.wait(
132-
w ->
133-
w.build().setWait(new TimeoutAfter().withDurationExpression("PT0.1S"))))
134-
.build();
135-
136-
long startTime = System.currentTimeMillis();
137-
WorkflowModel model = appl.workflowDefinition(workflow).instance(Map.of()).start().join();
138-
long elapsed = System.currentTimeMillis() - startTime;
139-
140-
assertThat(model).isNotNull();
141-
assertThat(elapsed).isGreaterThanOrEqualTo(100);
142-
}
143-
144124
@Test
145125
void testWaitWithDurationLiteralISO8601Milliseconds() {
146126
// PT0.1S = 100 milliseconds

0 commit comments

Comments
 (0)