Skip to content

Fixes bug where messages from frameId 0 weren't having sender.frameId set #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes bug where messages from frameId 0 weren't having sender.frameId set #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd522de
Fixes bug where messages from frameId 0 weren't having sender.frameId…
gurupras Jul 14, 2022
7f758b9
Fixes another instance where frameId checks weren't considering frame…
gurupras Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ function initIntercoms() {

const portFrame = incomingPort.sender.frameId

if (portFrame)
if (portFrame !== undefined)
Copy link

@mmxcrono mmxcrono May 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would allow nulls to pass this check. Should this be portFrame || portFrame === 0 instead?

portId = `${portId}.${portFrame}`

// literal tab id in case of content script, however tab id of inspected page in case of devtools context
Expand Down Expand Up @@ -202,7 +202,7 @@ export function routeMessage(message: IInternalMessage): void | Promise<void> {
: (`${(destName === 'window' ? 'content-script' : destName)}@${(destTabId || srcTabId)}`)

// Here it is checked if a specific frame needs to receive the message
if (destFrameId)
if (destFrameId !== undefined)
resolvedDestination = `${resolvedDestination}.${destFrameId}`

const destPort = portMap.get(resolvedDestination)
Expand Down