address bugbot comments

Author: icecrasher321

apps/sim/app/api/v1/admin/workflows/[id]/versions/[versionId]/activate/route.ts

@@ -85,6 +85,11 @@ export const POST = withAdminAuthParams<RouteParams>(async (request, context) =>
 
     const workflowData = workflowRecord as Record<string, unknown>
 
+    const scheduleValidation = validateWorkflowSchedules(blocks)
+    if (!scheduleValidation.isValid) {
+      return badRequestResponse(`Invalid schedule configuration: ${scheduleValidation.error}`)
+    }
+
     const triggerSaveResult = await saveTriggerWebhooksForDeploy({
       request,
       workflowId,
@@ -107,11 +112,6 @@ export const POST = withAdminAuthParams<RouteParams>(async (request, context) =>
       )
     }
 
-    const scheduleValidation = validateWorkflowSchedules(blocks)
-    if (!scheduleValidation.isValid) {
-      return badRequestResponse(`Invalid schedule configuration: ${scheduleValidation.error}`)
-    }
-
     const scheduleResult = await createSchedulesForDeploy(workflowId, blocks, db, versionRow.id)
 
     if (!scheduleResult.success) {

apps/sim/app/api/workflows/[id]/deployments/[version]/activate/route.ts

@@ -85,6 +85,11 @@ export async function POST(
       return createErrorResponse('Invalid deployed state structure', 500)
     }
 
+    const scheduleValidation = validateWorkflowSchedules(blocks)
+    if (!scheduleValidation.isValid) {
+      return createErrorResponse(`Invalid schedule configuration: ${scheduleValidation.error}`, 400)
+    }
+
     const triggerSaveResult = await saveTriggerWebhooksForDeploy({
       request,
       workflowId: id,
@@ -104,11 +109,6 @@ export async function POST(
       )
     }
 
-    const scheduleValidation = validateWorkflowSchedules(blocks)
-    if (!scheduleValidation.isValid) {
-      return createErrorResponse(`Invalid schedule configuration: ${scheduleValidation.error}`, 400)
-    }
-
     const scheduleResult = await createSchedulesForDeploy(id, blocks, db, versionRow.id)
 
     if (!scheduleResult.success) {

apps/sim/lib/webhooks/deploy.ts

@@ -623,7 +623,14 @@ export async function saveTriggerWebhooksForDeploy({
         requestId
       )
       if (pollingError) {
-        logger.warn(`[${requestId}] Polling configuration failed for ${sub.block.id}`, pollingError)
+        logger.error(
+          `[${requestId}] Polling configuration failed for ${sub.block.id}`,
+          pollingError
+        )
+        for (const block of triggerBlocks) {
+          ;(block as any)._webhookConfig = undefined
+        }
+        return { success: false, error: pollingError }
       }
     }
   } catch (error: any) {