fix(sms_operator): Fix message format for voice SMS messages

Author: Peter Kubov

pymess/backend/sms/sms_operator.py

@@ -111,7 +111,7 @@ def _serialize_messages(self, messages, request_type):
         # Determine the base template and type based on request type
         if request_type in [RequestType.VOICE_MESSAGE, RequestType.VOICE_MESSAGE_DELIVERY_REQUEST]:
             base_template = self.TEMPLATES['base_voice']
-            type_value = 'Voice' if request_type == RequestType.VOICE_MESSAGE else 'Voice-Status'
+            type_value = 'VoiceMessage' if request_type == RequestType.VOICE_MESSAGE else 'VoiceMessage-Status'
         else:
             base_template = self.TEMPLATES['base_sms']
             type_value = 'SMS' if request_type == RequestType.SMS else 'SMS-Status'

pymess/templates/pymess/sms/sms_operator/voice.xml

@@ -1,12 +1,9 @@
-<DataTemplate>
-  {% for message in messages %}
-    <DataItem>
-      {% if message.sender %}
-      <PhoneNumberMo>{{ message.sender }}</PhoneNumberMo>
-      {% endif %}
-      <MobileTerminate>{{ message.recipient }}</MobileTerminate>
-      <Text>{{ message.content }}</Text>
-      <MsgId>{{ prefix }}{{ message.pk }}</MsgId>
-    </DataItem>
-  {% endfor %}
-</DataTemplate>
+{% for message in messages %}
+<DataItem>
+  <MsgId>{{ prefix }}{{ message.pk }}</MsgId>
+  <PhoneNumber>{{ message.recipient }}</PhoneNumber>
+  <VoiceMsg>
+    <Text>{{ message.content }}</Text>
+  </VoiceMsg>
+</DataItem>
+{% endfor %}

tests/test_sms_operator_backend.py

@@ -36,12 +36,11 @@ def test_serialize_voice_message_should_use_voice_template(self, backend):
 
         assert root.tag == 'VoiceServices'
         header = root.find('./DataHeader/DataType')
-        assert header.text == 'Voice'
+        assert header.text == 'VoiceMessage'
         item = root.find('.//DataItem')
-        assert item.find('MobileTerminate').text == '+420111111111'
-        assert item.find('Text').text == 'Voice content'
+        assert item.find('PhoneNumber').text == '+420111111111'
+        assert item.find('./VoiceMsg/Text').text == 'Voice content'
         assert item.find('MsgId').text.endswith(str(message.pk))
-        assert item.find('PhoneNumberMo').text == 'CallerID'
 
     def test_serialize_sms_message_should_use_sms_template(self, backend):
         message = OutputSMSMessage.objects.create(