Closed
Conversation
Just realized you need full hunger for quick regen (oops)
co-author helped me match the code to the Java decomp. Works perfectly in parity with Java. Co-Authored-By: Alexandra-Myers <78748498+alexandra-myers@users.noreply.github.com>
|
Was it in the original LCE can't remember |
Contributor
Author
|
@starseed12345 Yes |
|
Is this the same as Java edition 1.6.4 or is this more similar/same as Java 1.11/Modern Legacy's natural regeneration? |
sylvessa
approved these changes
Apr 3, 2026
Contributor
|
will not be merged until later due to this following 1.11 quick regen math |
Contributor
|
the status about this even being added in lce is very hard, the documentation behind this in LCE is very vague and I can't confirm if quick regen was really a thing of this era, but this follows 1.11 quick regen math so this wont be merged, sorry. You are free to open a pr if you can verify that quick regen existed between TU19-TU24 and make sure the code follows the math it used. |
Contributor
Author
|
Ah yes, it was in TU31. The code does indeed match the decomp, so I will just keep it on hold for now. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added quick regeneration to the player code. A certain level of hunger/saturation are required for quickRegen to be enabled.
Changes
Previous Behavior
Did not heal according to saturation.
Root Cause
No code healed the player based on quick regen.
New Behavior
Now quick regen works.
Fix Implementation
Added new code in the player::aiStep to query saturation levels and subtract them in each heal. Operates on the same 3 saturation:half heart ratio as in modern LCE.
AI Use Disclosure
Related Issues