Skip to content

Commit 153d979

Browse files
committed
Fix #171 again
1 parent 2072c46 commit 153d979

22 files changed

+7744
-13
lines changed

__tests__/main.test.ts

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import { lineNumbers } from './test_compare_1/lineNumbers'
77
import { filesAdded, filesModified, filesRemoved } from './test_compare_1/filesChanged'
88

99
import { parseTscErrorLine, tscMatcher, parseOutputTsc } from '../src/tscHelpers/parseOutputTsc'
10+
import { getBodyComment } from '../src/getBodyComment'
1011

1112
test('1. parse tsc error line', () => {
1213
const line = `src/main.ts(39,11): error TS1155: 'const' declarations must be initialized.`
@@ -87,7 +88,7 @@ test('4. Parsing output', () => {
8788
expect(parsedErrors[0].extraMsg).toEqual("Type 'LastCnt' is missing the following properties from type 'SelectionPeriaDataCnt': catc_id, src_id")
8889
})
8990

90-
test('5. compare errors', () => {
91+
test('5. compare errors test 1', () => {
9192

9293
const resultCompareErrors = compareErrors({
9394
errorsBefore: errorsBaseBranch as unknown as ErrorTs[],
@@ -100,4 +101,22 @@ test('5. compare errors', () => {
100101

101102
expect(resultCompareErrors.errorsAdded).toHaveLength(15)
102103

104+
const errorsInModifiedFiles = errorsCurrentBranch.filter(err => {
105+
return filesModified.concat(filesAdded).includes(err.fileName)
106+
})
107+
108+
const newErrorsInModifiedFiles = resultCompareErrors.errorsAdded.filter(err => {
109+
return filesModified.concat(filesAdded).includes(err.fileName)
110+
})
111+
112+
const comment = getBodyComment({
113+
errorsInProjectBefore: errorsBaseBranch,
114+
errorsInProjectAfter: errorsCurrentBranch,
115+
newErrorsInProject: resultCompareErrors.errorsAdded,
116+
errorsInModifiedFiles,
117+
newErrorsInModifiedFiles
118+
})
119+
120+
expect(comment).toMatch(/\*\*15 new errors added\*\*/)
121+
103122
})

__tests__/test_compare_2.test.ts

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
import { compareErrors } from '../src/compareErrors'
2+
import { ErrorTs } from '../src/main'
3+
import { errorsCurrentBranch } from './test_compare_2/errorsCurrentBranch'
4+
import { errorsBaseBranch } from './test_compare_2/erreursBaseBranch'
5+
import { lineNumbers } from './test_compare_2/lineNumbers'
6+
import { filesAdded, filesModified, filesRemoved } from './test_compare_2/filesChanged'
7+
8+
test.skip('1. compare errors test 2', () => {
9+
10+
const resultCompareErrors = compareErrors({
11+
errorsBefore: errorsBaseBranch as unknown as ErrorTs[],
12+
errorsAfter: errorsCurrentBranch as unknown as ErrorTs[],
13+
filesChanged: filesModified.split(' '),
14+
filesAdded: filesAdded.split(' '),
15+
filesDeleted: filesRemoved.split(' '),
16+
lineNumbers: lineNumbers
17+
})
18+
19+
expect(resultCompareErrors.errorsAdded).toHaveLength(2)
20+
21+
})

__tests__/test_compare_2/erreursBaseBranch.js

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

__tests__/test_compare_2/erreursBaseBranch.ts

Lines changed: 1 addition & 0 deletions
Large diffs are not rendered by default.

__tests__/test_compare_2/errorsCurrentBranch.js

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

__tests__/test_compare_2/errorsCurrentBranch.ts

Lines changed: 1 addition & 0 deletions
Large diffs are not rendered by default.

__tests__/test_compare_2/filesChanged.js

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
export const filesModified = 'server/api/contrats/services/GetInfosCnt.ts server/payrollEngine/PayrollEngine.ts server/payrollEngine/declaCalc.d.ts server/payrollEngine/selectBulsToRecalculate.ts'
2+
export const filesAdded = ''
3+
export const filesRemoved = ''

__tests__/test_compare_2/lineNumbers.js

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export const lineNumbers = [{ "path": "server/api/contrats/services/GetInfosCnt.ts", "added": [177], "removed": [177] }, { "path": "server/payrollEngine/PayrollEngine.ts", "added": [315, 316, 317, 318, 319, 320, 321, 322, 323], "removed": [] }, { "path": "server/payrollEngine/declaCalc.d.ts", "added": [111, 127], "removed": [] }, { "path": "server/payrollEngine/selectBulsToRecalculate.ts", "added": [195, 196, 197, 198, 199, 219, 220, 243, 244, 291, 343, 591, 639, 640, 646, 647, 648], "removed": [195, 196, 197, 198, 218, 219, 242, 634, 640, 641] }]

0 commit comments

Comments
 (0)