Skip to content
This repository was archived by the owner on Aug 22, 2025. It is now read-only.

Conversation

@0xAurelius
Copy link
Contributor

@0xAurelius 0xAurelius commented Feb 21, 2024

Increases flexibility of the Gitcoin Passport validation strategy for use by KlimaDAO

Changes proposed in this pull request:

  • Adds a new ">=N" operator that allows for a fixed number of valid stamps to be required, rather than only "at least one" (OR) or "all" (AND)
  • Allows expired stamps to be considered valid by setting a boolean flag checkExpired which is true by default (i.e. expired stamps do not count by default)

@ChaituVR ChaituVR changed the title Add at least N operator and checkExpiration flag to Gitcoin Passport validation strategy [passport-gated] Add at least N operator and checkExpiration flag to Gitcoin Passport validation strategy Feb 22, 2024
@ChaituVR ChaituVR added the validation To run test cases related to validations label Feb 22, 2024
@0xAurelius
Copy link
Contributor Author

Not sure why the validation tests are failing, looks like a problem with the GitHub Actions CI setup when talking to Gitcoin Passport:
image

@0xAurelius 0xAurelius changed the title [passport-gated] Add at least N operator and checkExpiration flag to Gitcoin Passport validation strategy [passport-gated] Add at least N operator and checkExpired flag to Gitcoin Passport validation strategy Feb 26, 2024
@0xAurelius 0xAurelius force-pushed the master branch 2 times, most recently from dcf8b1b to 1774d3a Compare February 26, 2024 20:15
@0xAurelius 0xAurelius requested a review from ChaituVR February 26, 2024 20:19
@ChaituVR ChaituVR removed their request for review July 13, 2025 03:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

validation To run test cases related to validations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants