Merge branch 'main' into aalam-SNOW-2097908-add-versioned-params-for-optimizations

Author: sfc-gh-aalam

.github/workflows/daily_modin_precommit_py39_py310.yml

@@ -62,8 +62,8 @@ jobs:
           name: wheel
           path: dist/
 
-  test-unsupported-py38:
-    name: Test importing Snowpark pandas with Python 3.8 fails
+  test-unsupported-modin-or-pandas:
+    name: Test importing unsupported modin or pandas
     needs: build
     runs-on: ubuntu-latest
     steps:
@@ -72,16 +72,16 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v4
         with:
-          python-version: 3.8
+          python-version: 3.9
       - name: Install protoc
         shell: bash
         run: .github/scripts/install_protoc.sh
       - name: Upgrade setuptools and pip
         run: python -m pip install -U setuptools pip
       - name: Install tox
         run: python -m pip install tox
-      - name: Ensure importing Snowpark pandas fails on Python 3.8
-        run: tox -e snowpark_pandas_py38_import_error
+      - name: Ensure importing unsupported modin or pandas versions fails
+        run: tox -e snowpark_pandas_modin_pandas_import_error
 
   test-old-np:
     name: Tests that Snowpark pandas works with numpy 1.26
@@ -110,6 +110,33 @@ jobs:
       - name: Ensure importing Snowpark pandas with numpy 1.26 works
         run: tox -e snowpark_pandas_old_np
 
+  test-old-modin:
+    name: Tests that Snowpark pandas works with previous modin version
+    needs: build
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v4
+      - name: Set up Python
+        uses: actions/setup-python@v4
+        with:
+          python-version: 3.9
+      - name: Decrypt parameters.py
+        shell: bash
+        run: .github/scripts/decrypt_parameters.sh
+        env:
+          PARAMETER_PASSWORD: ${{ secrets.PARAMETER_PASSWORD }}
+          CLOUD_PROVIDER: "aws"
+      - name: Install protoc
+        shell: bash
+        run: .github/scripts/install_protoc.sh
+      - name: Upgrade setuptools and pip
+        run: python -m pip install -U setuptools pip
+      - name: Install tox
+        run: python -m pip install tox
+      - name: Run tests
+        run: tox -e modin_previous_version-snowparkpandasdailynotdoctest-modin-ci
+
   test:
     name: Test modin-${{ matrix.os.download_name }}-${{ matrix.python-version }}-${{ matrix.cloud-provider }}
     needs: build

.github/workflows/daily_precommit.yml

@@ -98,7 +98,7 @@ jobs:
             download_name: macos
           - image_name: windows-latest-64-cores
             download_name: windows
-        python-version: ["3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
         cloud-provider: [aws, azure, gcp]
     steps:
       - name: Checkout Code
@@ -134,7 +134,8 @@ jobs:
         run: python -m pip install -U setuptools pip wheel
       - name: Install tox
         run: python -m pip install tox
-      - if: ${{ contains('macos', matrix.os.download_name) }}
+      # SNOW-2213578: Re-enable the test for 3.13
+      - if: ${{ contains('macos', matrix.os.download_name) && matrix.python-version != '3.13' }}
         name: Run doctests
         run: python -m tox -e "py${PYTHON_VERSION}-doctest-notudf-ci"
         env:
@@ -145,15 +146,28 @@ jobs:
           # Specify SNOWFLAKE_IS_PYTHON_RUNTIME_TEST: 1 when adding >= python3.12 with no server-side support
           # For example, see https://github.com/snowflakedb/snowpark-python/pull/681
         shell: bash
-      - name: Run tests (excluding doctests)
+      - if: ${{ matrix.python-version != '3.13' }}
+        name: Run tests (excluding doctests)
         run: python -m tox -e "py${PYTHON_VERSION/\./}-dailynotdoctest-ci"
         env:
           PYTHON_VERSION: ${{ matrix.python-version }}
           cloud_provider: ${{ matrix.cloud-provider }}
           PYTEST_ADDOPTS: --color=yes --tb=short
           TOX_PARALLEL_NO_SPINNER: 1
         shell: bash
+      # SNOW-2213578 : Remove the test below and run udf tests for 3.13
+      - if: ${{ matrix.python-version == '3.13' }}
+        name: Run tests (excluding udf, doctests)
+        run: python -m tox -e "py${PYTHON_VERSION/\./}-dailynotdoctestnotudf-ci"
+        env:
+          PYTHON_VERSION: ${{ matrix.python-version }}
+          cloud_provider: ${{ matrix.cloud-provider }}
+          PYTEST_ADDOPTS: --color=yes --tb=short
+          TOX_PARALLEL_NO_SPINNER: 1
+        shell: bash
       - name: Run data source tests
+        # psycopg2 is not supported on macos 3.9
+        if: ${{ !(contains('macos', matrix.os.download_name) && matrix.python-version == '3.9') }}
         run: python -m tox -e datasource
         env:
           PYTHON_VERSION: ${{ matrix.python-version }}
@@ -360,8 +374,8 @@ jobs:
       fail-fast: false
       matrix:
         os: [macos-latest, windows-latest, ubuntu-latest]
-        python-version: ["3.9", "3.10", "3.11", "3.12"]
-        cloud-provider: [aws]
+        python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
+        cloud-provider: [azure]
     steps:
       - name: Checkout Code
         uses: actions/checkout@v4
@@ -426,8 +440,8 @@ jobs:
       fail-fast: false
       matrix:
         os: [macos-latest, windows-latest, ubuntu-latest]
-        python-version: ["3.9", "3.10", "3.11", "3.12"]
-        cloud-provider: [aws]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]  # SNOW-2230787 test failing on Python 3.13
+        cloud-provider: [gcp]
         protobuf-version: ["3.20.1", "4.25.3", "5.28.3"]
     steps:
       - name: Checkout Code
@@ -490,8 +504,8 @@ jobs:
         os:
           - image_name: macos-latest
             download_name: macos  # it includes doctest
-        python-version: ["3.9", "3.10", "3.11", "3.12"]
-        cloud-provider: [aws]
+        python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
+        cloud-provider: [azure]
     steps:
       - name: Checkout Code
         uses: actions/checkout@v4
@@ -531,14 +545,25 @@ jobs:
           PYTEST_ADDOPTS: --color=yes --tb=short --disable_cte_optimization
           TOX_PARALLEL_NO_SPINNER: 1
         shell: bash
-      - name: Run tests (excluding doctests)
+      - if: ${{ matrix.python-version != '3.13' }}
+        name: Run tests (excluding doctests)
         run: python -m tox -e "py${PYTHON_VERSION/\./}-dailynotdoctest-ci"
         env:
           PYTHON_VERSION: ${{ matrix.python-version }}
           cloud_provider: ${{ matrix.cloud-provider }}
           PYTEST_ADDOPTS: --color=yes --tb=short --disable_cte_optimization
           TOX_PARALLEL_NO_SPINNER: 1
         shell: bash
+      # SNOW-2213578 : Remove the test below and run udf tests for 3.13
+      - if: ${{ matrix.python-version == '3.13' }}
+        name: Run tests (excluding udf, doctests)
+        run: python -m tox -e "py${PYTHON_VERSION/\./}-dailynotdoctestnotudf-ci"
+        env:
+          PYTHON_VERSION: ${{ matrix.python-version }}
+          cloud_provider: ${{ matrix.cloud-provider }}
+          PYTEST_ADDOPTS: --color=yes --tb=short --disable_cte_optimization
+          TOX_PARALLEL_NO_SPINNER: 1
+        shell: bash
       - name: Combine coverages
         run: python -m tox -e coverage --skip-missing-interpreters false
         shell: bash