Remove deprecated functions from cli

[thsioutas]

Hello! I wanted to ask you if this: solana-labs/solana-program-library#6305 still needs to be addressed?

I was checking the code and I don't really see the added value of the deprecated is_valid_pubkey here:

single-pool/clients/cli/src/cli.rs

Line 319 in 2292cb2

if is_valid_pubkey(path).is_ok() {

Why don't we use directly pubkey_from_path? is_valid_pubkey uses SignerSource::parse which is also used in pubkey_from_path for the necessary parsing.

p.s. I was trying to find a note or something regarding open issues from the old read-only repo but couldn't find something relevant.

Thanks in advance!

[joncinque]

It does still need to be addressed! You've outlined pretty much the exact way to handle the issue -- through parsers instead of validators.

You can see a PR removing the deprecated functions for the token-cli at solana-labs/solana-program-library#7447 if you want some inspiration