Add components-return-once to build.

Author: joshwilsonvu

README.md

@@ -84,6 +84,7 @@ would like to use.
 <!-- AUTO-GENERATED-CONTENT:START (RULES) -->
 | ✔ | 🔧 | Rule | Description |
 | :---: | :---: | :--- | :--- |
+| ✔ | 🔧 | [solid/components-return-once](docs/components-return-once.md) | Disallow early returns in components. Solid components only run once, and so conditionals should be inside JSX. |
 | ✔ | 🔧 | [solid/event-handlers](docs/event-handlers.md) | Enforce naming DOM element event handlers consistently and prevent Solid's analysis from misunderstanding whether a prop should be an event handler. |
 | ✔ | 🔧 | [solid/jsx-no-undef](docs/jsx-no-undef.md) | Disallow references to undefined variables in JSX. Handles custom directives. |
 | ✔ |  | [solid/jsx-uses-vars](docs/jsx-uses-vars.md) | Prevent variables used in JSX from being marked as unused. |

src/index.ts

@@ -1,3 +1,4 @@
+import componentsReturnOnce from "./rules/components-return-once";
 import eventHandlers from "./rules/event-handlers";
 import jsxNoUndef from "./rules/jsx-no-undef";
 import jsxUsesVars from "./rules/jsx-uses-vars";
@@ -13,6 +14,7 @@ import reactivity from "./rules/reactivity";
 import styleProp from "./rules/style-prop";
 
 const allRules = {
+  "components-return-once": componentsReturnOnce,
   "event-handlers": eventHandlers,
   "jsx-no-undef": jsxNoUndef,
   "jsx-uses-vars": jsxUsesVars,
@@ -53,6 +55,7 @@ module.exports = {
         // incorrect usages of innerHTML are security errors
         "solid/no-innerhtml": [2, { allowStatic: true }],
         // reactivity
+        "solid/components-return-once": 1,
         "solid/no-destructure": 2,
         "solid/prefer-for": 2,
         "solid/reactivity": 1,
@@ -78,6 +81,7 @@ module.exports = {
         // incorrect usages of innerHTML and <For /> are security or logic errors
         "solid/no-innerhtml": [2, { allowStatic: true }],
         // reactivity
+        "solid/components-return-once": 1,
         "solid/no-destructure": 2,
         "solid/prefer-for": 2,
         "solid/reactivity": 1,

test/rules/components-return-once.test.ts

@@ -23,11 +23,20 @@ export const cases = run("components-return-once", rule, {
     // Early returns
     {
       code: `function Component() {
-  if (condition) {
-    return <div />;
-  };
-  return <span />;
-}`,
+        if (condition) {
+          return <div />;
+        };
+        return <span />;
+      }`,
+      errors: [{ messageId: "noEarlyReturn" }],
+    },
+    {
+      code: `const Component = () => {
+        if (condition) {
+          return <div />;
+        }
+        return <span />;
+      }`,
       errors: [{ messageId: "noEarlyReturn" }],
     },
     // Balanced ternaries