-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix spelling and revert correct terms in Console Design HLD #2130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lihuay
wants to merge
2
commits into
master
Choose a base branch
from
fix/console-design-spelling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -110,16 +110,16 @@ This document describes the functionality and high level design of the Console s | |
|
|
||
| | Term | Meaning | ||
| |---|---| | ||
| | SSH | **S**ecure **S**hell | | ||
| | SSH | **S**ecure **Sh**ell | | ||
| | CLI | **C**ommand **L**ine **I**nterface | | ||
| | OS | **O**perating **S**ystem | | ||
| | USB | **U**niversal **S**erial **B**us | | ||
| | TTY | **T**ele**TY**pewriter, terminal for text input/output environment | | ||
| | PID | **P**rocess **ID**entification number | | ||
| | PID | **P**process **ID**entification number | | ||
| | ETH | **ETH**ernet | | ||
| | UTC | **C**oordinated **U**niversal **T**ime | | ||
| | MGMT | **M**ana**G**e**M**en**T** | | ||
| | TCP | **T**ransmission **C**ontrol **P**rotocol | | ||
| | TCP | **T**ransmission **C**control **P**rotocol | | ||
lihuay marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| # 1 Feature Overview | ||
|
|
||
|
|
@@ -269,8 +269,8 @@ ssh tom@2001:db8::1 | |
| # connect to DeviceB | ||
| ssh tom@2001:db8::2 | ||
|
|
||
| # Assume that domain name DeviceC.co point to 2001:db8::3 | ||
| ssh tom@DeviceC.co | ||
| # Assume that domain name devicec.co point to 2001:db8::3 | ||
|
||
| ssh tom@devicec.co | ||
lihuay marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ``` | ||
|
|
||
| The mechanism behind it is actually very similar to mode A. We will record the target ssh host IP address to a environment variable `$SSH_TARGET_IP`. Since we have stored the relationship between line number and it's management IP, then we can easily start the management session automatically after user login by calling `consutil connect` command in `/etc/bash.bashrc`. If the management IP were not found in config db (consutil connect failed due to target not found), then we will fall back to normal SONiC management bash session. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.