Fix UnboundLocalError in test_buffer_deployment #21471
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuChen-MSFT
requested review from
StormLiangMS,
ZhaohuiS and
wsycqyz
and removed request for
nikamirrr,
wangxin and
yxieca
XuChen-MSFT
added
Request for 202505 branch
Request for 202511 branch
ZhaohuiS
approved these changes
Nov 28, 2025
Contributor
ZhaohuiS
left a comment
ZhaohuiS
left a comment
There was a problem hiding this comment.
thanks for the quick fix
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…deployment‘
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR fixes an UnboundLocalError that occurs in the test_buffer_deployment test case when buffer_profile_oid is None.
During test execution on some testbed, the test failed when processing
pg_lossless_XXXX_profilebecause:is_ingress_lossless = True)buffer_profile_oidreturned None from_check_port_buffer_info_and_get_profile_oidbuffer_profile_asic_infowas never definedbuffer_profile_asic_info['SAI_BUFFER_PROFILE_ATTR_POOL_ID'], causing the errorHow did you do it?
if buffer_profile_oid:blockbuffer_profile_asic_infois only accessed when it has been properly definedprofiles_checked[expected_profile]outside the block to preserve existing behaviorThis fix ensures the test handles cases where buffer_profile_oid is None without crashing, allowing the test to continue or fail gracefully with proper assertion messages.
How did you verify/test it?
local test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation