Always :VVV, @vvv, $VVV as named params

Even in cases where VVV is a numeric value,
these are considered named parameters by sqlite.

Author: captn3m0

ext/sqlite3/statement.c

@@ -484,15 +484,12 @@ named_params(VALUE self)
     // The first host parameter has an index of 1, not 0.
     for (int i = 1; i <= param_count; i++) {
         const char *name = sqlite3_bind_parameter_name(ctx->st, i);
-        // If parameters of the ?NNN/$NNN/@NNN/:NNN form are used
-        // there may be gaps in the list.
-        if (name) {
+        // We ignore numbered parameters (starting with ?)
+        // And null values, since there can be gaps in the list
+        if (name && *name != '?') {
             // We ignore numeric parameters
-            int n = atoi(name + 1);
-            if (n == 0) {
-                VALUE param = interned_utf8_cstr(name + 1);
-                rb_ary_push(params, param);
-            }
+            VALUE param = interned_utf8_cstr(name + 1);
+            rb_ary_push(params, param);
         }
     }
     return rb_obj_freeze(params);

test/test_statement.rb

@@ -257,8 +257,8 @@ def test_named_bind_not_found
     end
 
     def test_params
-      stmt = SQLite3::Statement.new(@db, "select  ?1, :foo, ?, $bar, @zed, ?250, @999")
-      assert_equal ["foo", "bar", "zed"], stmt.named_params
+      stmt = SQLite3::Statement.new(@db, "select  ?1, :foo, ?, $bar, @zed, ?250, @999, :123, $777")
+      assert_equal ["foo", "bar", "zed", "999", "123", "777"], stmt.named_params
       stmt.close
     end