Fixed linting errors and removed unused commented code.

Signed-off-by: Nichol Yip <[email protected]>

Author: Nichol Yip

crates/spk-schema/src/environ.rs

@@ -106,17 +106,6 @@ impl EnvOp {
             Self::Set(op) => op.tcsh_source(),
         }
     }
-
-    // /// Returns the lint message for the given EnvOp
-    // pub fn lints(&self, unknown_key: &str) -> String {
-    //     match self {
-    //         Self::Append(op) => op.generate_lints(unknown_key),
-    //         Self::Comment(op) => op.generate_lints(unknown_key),
-    //         Self::Prepend(op) => op.generate_lints(unknown_key),
-    //         Self::Priority(op) => op.generate_lints(unknown_key),
-    //         Self::Set(op) => op.generate_lints(unknown_key),
-    //     }
-    // }
 }
 
 #[derive(Clone, Debug, Eq, Hash, Ord, PartialEq, PartialOrd, Serialize, Deserialize)]

crates/spk-schema/src/source_spec.rs

@@ -85,26 +85,26 @@ impl Lints for SourceSpecVisitor {
 
 impl From<SourceSpecVisitor> for SourceSpec {
     fn from(value: SourceSpecVisitor) -> Self {
-        if !value.path.is_none() {
+        if value.path.is_some() {
             SourceSpec::Local(LocalSource {
                 path: value.path.expect("a path source"),
                 exclude: value.exclude.unwrap_or(LocalSource::default_exclude()),
                 filter: value.filter.unwrap_or(LocalSource::default_filter()),
                 subdir: value.subdir,
             })
-        } else if !value.git.is_none() {
+        } else if value.git.is_some() {
             SourceSpec::Git(GitSource {
                 git: value.git.expect("a git source"),
                 reference: value.reference.unwrap_or(String::from("")),
                 depth: value.depth.unwrap_or(default_git_clone_depth()),
                 subdir: value.subdir,
             })
-        } else if !value.script.is_none() {
+        } else if value.script.is_some() {
             SourceSpec::Script(ScriptSource {
                 script: value.script.expect("a script source"),
                 subdir: value.subdir,
             })
-        } else if !value.tar.is_none() {
+        } else if value.tar.is_some() {
             SourceSpec::Tar(TarSource {
                 tar: value.tar.expect("a tar source"),
                 subdir: value.subdir,