Handle malformed OpenAI API responses

Signed-off-by: Christian Tzolov <[email protected]>

Author: tzolov

models/spring-ai-openai/src/main/java/org/springframework/ai/openai/OpenAiChatModel.java

@@ -428,7 +428,7 @@ private Generation buildGeneration(Choice choice, Map<String, Object> metadata,
 		List<Media> media = new ArrayList<>();
 		String textContent = choice.message().content();
 		var audioOutput = choice.message().audioOutput();
-		if (audioOutput != null) {
+		if (audioOutput != null && StringUtils.hasText(audioOutput.data()) && request.audioParameters() != null) {
 			String mimeType = String.format("audio/%s", request.audioParameters().format().name().toLowerCase());
 			byte[] audioData = Base64.getDecoder().decode(audioOutput.data());
 			Resource resource = new ByteArrayResource(audioData);

models/spring-ai-openai/src/main/java/org/springframework/ai/openai/api/OpenAiApi.java

@@ -758,6 +758,11 @@ public String getName() {
 	 */
 	public enum ChatCompletionFinishReason {
 
+		/**
+		 * Handles, empty, NULL and unknown values
+		 */
+		@JsonProperty("")
+		UNKNOWN,
 		/**
 		 * The model hit a natural stop point or a provided stop sequence.
 		 */

models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/OpenAiCompatibleChatModelIT.java

@@ -66,7 +66,7 @@ static Stream<ChatModel> openAiCompatibleApis() {
 					.baseUrl("https://api.groq.com/openai")
 					.apiKey(System.getenv("GROQ_API_KEY"))
 					.build())
-				.defaultOptions(forModelName("llama3-8b-8192"))
+				.defaultOptions(forModelName("meta-llama/llama-4-scout-17b-16e-instruct"))
 				.build());
 		}
 

models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/OpenAiStreamingFinishReasonTests.java

@@ -143,10 +143,7 @@ void testJsonDeserializationWithEmptyStringFinishReason() throws JsonProcessingE
 		assertThat(choice.index()).isEqualTo(0);
 		assertThat(choice.delta().content()).isEmpty();
 
-		// The key test: what happens with empty string finish_reason?
-		// This might be null if Jackson handles empty string -> enum conversion
-		// gracefully
-		assertThat(choice.finishReason()).isNull();
+		assertThat(choice.finishReason()).isEqualTo(ChatCompletionFinishReason.UNKNOWN);
 	}
 
 	@Test
@@ -245,7 +242,7 @@ void testModelOptionsUtilsJsonToObjectWithEmptyFinishReason() {
 
 		var choice = chunk.choices().get(0);
 		// The critical test: how does ModelOptionsUtils handle empty string -> enum?
-		assertThat(choice.finishReason()).isNull();
+		assertThat(choice.finishReason()).isEqualTo(ChatCompletionFinishReason.UNKNOWN);
 	}
 
 	private void setupChatModel() {

models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/proxy/GroqWithOpenAiChatModelIT.java

@@ -73,7 +73,7 @@ class GroqWithOpenAiChatModelIT {
 
 	private static final String GROQ_BASE_URL = "https://api.groq.com/openai";
 
-	private static final String DEFAULT_GROQ_MODEL = "llama3-70b-8192";
+	private static final String DEFAULT_GROQ_MODEL = "llama-3.1-8b-instant";
 
 	@Value("classpath:/prompts/system-message.st")
 	private Resource systemResource;
@@ -373,7 +373,7 @@ void streamingMultiModalityImageUrl() throws IOException {
 	}
 
 	@ParameterizedTest(name = "{0} : {displayName} ")
-	@ValueSource(strings = { "llama3-8b-8192", "llama3-70b-8192", "mixtral-8x7b-32768", "gemma-7b-it" })
+	@ValueSource(strings = { "meta-llama/llama-4-scout-17b-16e-instruct" })
 	void validateCallResponseMetadata(String model) {
 		// @formatter:off
 		ChatResponse response = ChatClient.create(this.chatModel).prompt()

models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/proxy/MultiOpenAiClientIT.java

@@ -64,7 +64,10 @@ void multiClientFlow() {
 		// Derive a new OpenAiChatModel for Groq
 		OpenAiChatModel groqModel = this.baseChatModel.mutate()
 			.openAiApi(groqApi)
-			.defaultOptions(OpenAiChatOptions.builder().model("llama3-70b-8192").temperature(0.5).build())
+			.defaultOptions(OpenAiChatOptions.builder()
+				.model("meta-llama/llama-4-scout-17b-16e-instruct")
+				.temperature(0.5)
+				.build())
 			.build();
 
 		// Derive a new OpenAiChatModel for GPT-4