removes --reuse-values flag and updates version#611
Merged
Conversation
Signed-off-by: Chris Burns <29541485+ChrisJBurns@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Kubernetes operator deployment guide to discourage use of Helm’s --reuse-values during upgrades and refreshes the referenced ToolHive chart/CRD versions.
Changes:
- Bumps example CRD and operator chart versions from
0.8.3to0.12.1(andv0.8.3tov0.12.1in raw manifest URLs). - Removes
--reuse-valuesfrom operator upgrade command examples.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
359
to
+367
| ```bash | ||
| helm upgrade -i toolhive-operator oci://ghcr.io/stacklok/toolhive/toolhive-operator -n toolhive-system --reuse-values | ||
| helm upgrade -i toolhive-operator oci://ghcr.io/stacklok/toolhive/toolhive-operator -n toolhive-system | ||
| ``` | ||
|
|
||
| This upgrades the operator to the latest version available in the OCI registry. | ||
| To upgrade to a specific version, add the `--version` flag: | ||
|
|
||
| ```bash | ||
| helm upgrade -i toolhive-operator oci://ghcr.io/stacklok/toolhive/toolhive-operator -n toolhive-system --reuse-values --version 0.8.3 | ||
| helm upgrade -i toolhive-operator oci://ghcr.io/stacklok/toolhive/toolhive-operator -n toolhive-system --version 0.12.1 |
danbarr
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We don't want to recommend users use
--reuse-valuesbecause its a footgun for Helm and causes issues when updating Charts as it leaves the images on older versions.Also updates the ToolHive version to a more recent version.
Type of change
Submitter checklist
Content and formatting
Reviewer checklist
Content