Repository navigation
chore(deps): bump action_kit_test to v1.4.13 - #90
Merged
Merged
Conversation
Merges e2e coverage across all WithMinikube runs, instead of keeping only the last one. The self-signed certificate e2e tests start extra minikubes after the main suite, so Sonar only saw the last of them.
|
Claude finished @achoimet's task in 9s —— View job Review of PR #90No issues found. The diff changes only
There were no prior review threads of mine to resolve. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the e2e coverage that Sonar stopped seeing after the self-signed certificate tests were added.
action_kit_testwrote every minikube run's coverage to the samee2e/e2e-coverage-docker.out. The self-signed certificate e2e tests start one minikube per configuration after the main suite, so only the last of those runs reached Sonar. Coverage on main went 80.6 → 76.1. v1.4.13 merges all runs of the test binary into the report (steadybit/action-kit#527).v1.4.13 also makes
Extension.Reconfigurework for Deployments (steadybit/action-kit#526). This PR doesn't use it yet.Only
go.mod/go.sumchange; the k8s patch bumps come from v1.4.13's own requirements. Verified locally:go build,go vet, and every test package (e2e included) compiles. CI runs the full audit including e2e, and its Sonar analysis shows the restored coverage.